Why this change is needed:
LightRAG creates storage instances by passing its own self.workspace field,
not the workspace parameter from vector_db_storage_cls_kwargs. This caused
E2E tests to fail because the workspace was set to default "_" instead of
the configured value like "prod" or "workspace_a".
How it solves it:
- Pass workspace directly to LightRAG constructor as a field parameter
- Remove workspace from vector_db_storage_cls_kwargs where it was being ignored
- This ensures self.workspace is set correctly and propagated to storage instances
Impact:
- Fixes test_backward_compat_old_workspace_naming_qdrant migration failure
- Fixes test_workspace_isolation_e2e_qdrant workspace mismatch
- Proper workspace isolation is now enforced in E2E tests
Testing:
- Modified two Qdrant E2E tests to use correct workspace configuration
- Tests should now find correct legacy collections (e.g., prod_chunks)
Why this change is needed:
Offline tests were failing with "ModuleNotFoundError: No module named 'qdrant_client'"
because test_e2e_multi_instance.py was being imported during test collection, even
though it's an E2E test that shouldn't run in offline mode. Pytest imports all test
files during collection phase regardless of marks, causing import errors for missing
E2E dependencies (qdrant_client, asyncpg, etc.).
Additionally, the test mocks for PostgreSQL migration were too permissive - they
accepted any parameter format without validation, which allowed bugs (like passing
dict instead of positional args to AsyncPG execute()) to slip through undetected.
How it solves it:
1. E2E Import Fix:
- Use pytest.importorskip() to conditionally import qdrant_client
- E2E tests are now skipped cleanly when dependencies are missing
- Offline tests can collect and run without E2E dependencies
2. Stricter Test Mocks:
- Enhanced mock_pg_db fixture to validate AsyncPG parameter format
- Mock execute() now raises TypeError if dict/list passed as single argument
- Ensures tests catch parameter passing bugs that would fail in production
3. Parameter Validation Test:
- Added test_postgres_migration_params.py for explicit parameter validation
- Verifies migration passes positional args correctly to AsyncPG
- Provides detailed output for debugging parameter issues
Impact:
- Offline tests no longer fail due to missing E2E dependencies
- Future bugs in AsyncPG parameter passing will be caught by tests
- Better test isolation between offline and E2E test suites
- Improved test coverage for migration parameter handling
Testing:
- Verified with `pytest tests/ -m offline -v` - no import errors
- All PostgreSQL migration tests pass (6/6 unit + 1 strict validation)
- Pre-commit hooks pass (ruff-format, ruff)
Why this change is needed:
The previous test coverage had gaps in critical migration scenarios that could lead
to data loss or broken upgrades for users migrating from old versions of LightRAG.
What was added:
1. E2E Tests (test_e2e_multi_instance.py):
- test_case1_both_exist_warning_qdrant: Verify warning when both collections exist
- test_case2_only_new_exists_qdrant: Verify existing collection reuse
- test_backward_compat_old_workspace_naming_qdrant: Test old workspace naming migration
- test_empty_legacy_qdrant: Verify empty legacy collection handling
- test_workspace_isolation_e2e_qdrant: Validate workspace data isolation
2. Unit Tests (test_migration_complete.py):
- All 4 migration cases (new+legacy, only new, only legacy, neither)
- Backward compatibility tests for multiple legacy naming patterns
- Empty legacy migration scenario
- Workspace isolation verification
- Model switching scenario
- Full migration lifecycle integration test
How it solves it:
These tests validate the _find_legacy_collection() backward compatibility fix with
real Qdrant database instances, ensuring smooth upgrades from all legacy versions.
Impact:
- Prevents regressions in migration logic
- Validates backward compatibility with old naming schemes
- Ensures workspace isolation works correctly
- Will run in CI pipeline to catch issues early
Testing:
All 20+ tests pass locally. E2E tests will validate against real Qdrant in CI.
Remove unused embedding functions (C and D) that were defined but never
used, causing F841 lint errors.
Also fix E712 errors by using 'is True' instead of '== True' for
boolean comparisons in assertions.
Testing:
- All pre-commit hooks pass
- Verified with: uv run pre-commit run --all-files
Why this change is needed:
E2E PostgreSQL tests were failing because they specified graph_storage="PGGraphStorage",
but the CI environment doesn't have the Apache AGE extension installed. This caused
initialize_storages() to fail with "function create_graph(unknown) does not exist".
How it solves it:
Removed graph_storage="PGGraphStorage" parameter in all PostgreSQL E2E tests,
allowing LightRAG to use the default NetworkXStorage which doesn't require
external dependencies.
Impact:
- PostgreSQL E2E tests can now run successfully in CI
- Vector storage migration tests can complete without AGE extension dependency
- Maintains test coverage for vector storage model isolation feature
Testing:
The vector storage migration tests (which are the focus of this PR) don't
depend on graph storage implementation and can run with NetworkXStorage.
Why this change is needed:
Tests were accessing rag.chunk_entity_relation_graph.chunk_vdb which
doesn't exist. The chunk_entity_relation_graph is a BaseGraphStorage
and doesn't have a chunk_vdb attribute.
How it solves it:
Changed all occurrences to use direct LightRAG attributes:
- rag.chunks_vdb.table_name (PostgreSQL)
- rag.chunks_vdb.final_namespace (Qdrant)
Impact:
Fixes AttributeError that would occur when E2E tests run
Testing:
Will verify on GitHub Actions E2E test run
Why this change is needed:
E2E tests were failing with TypeError because they used non-existent
parameters kv_storage_cls_kwargs, graph_storage_cls_kwargs, and
doc_status_storage_cls_kwargs. These parameters do not exist in
LightRAG's __init__ method.
How it solves it:
Removed the three non-existent parameters from all LightRAG initializations
in test_e2e_multi_instance.py:
- test_legacy_migration_postgres
- test_multi_instance_postgres (both instances A and B)
PostgreSQL storage classes (PGKVStorage, PGGraphStorage, PGDocStatusStorage)
use ClientManager which reads configuration from environment variables
(POSTGRES_HOST, POSTGRES_PORT, etc.) that are already set in the E2E
workflow, so no additional kwargs are needed.
Impact:
- Fixes TypeError on LightRAG initialization
- E2E tests can now properly instantiate with PostgreSQL storages
- Configuration still works via environment variables
Testing:
Next E2E run should successfully initialize LightRAG instances
and proceed to actual migration/multi-instance testing.
Why this change is needed:
Complete E2E test coverage for vector model isolation feature requires
testing legacy data migration for both PostgreSQL and Qdrant backends.
Previously only PostgreSQL migration was tested.
How it solves it:
- Add test_legacy_migration_qdrant() function to test automatic migration
from legacy collection (no model suffix) to model-suffixed collection
- Test creates legacy "lightrag_vdb_chunks" collection with 1536d vectors
- Initializes LightRAG with model_name="text-embedding-ada-002"
- Verifies automatic migration to "lightrag_vdb_chunks_text_embedding_ada_002_1536d"
- Validates vector count, dimension, and collection existence
Impact:
- Ensures Qdrant migration works correctly in real scenarios
- Provides parity with PostgreSQL E2E test coverage
- Will be automatically run in CI via -k "qdrant" filter
Testing:
- Test follows same pattern as test_legacy_migration_postgres
- Uses complete LightRAG initialization with mock LLM and embedding
- Includes proper cleanup via qdrant_cleanup fixture
- Syntax validated with python3 -m py_compile
