From 382d2d0373fea9554982a0718fc8eaf5fe8a5807 Mon Sep 17 00:00:00 2001
From: Stephen Hu <stephenhu@seismic.com>
Date: Tue, 24 Jun 2025 13:17:22 +0800
Subject: [PATCH] Refactor:Improve insert file logic (#8445)

### What problem does this PR solve?

before refactor
1. create file record
2. Add to blob

if have some execption at 2 the system db will have a file record but
not have related blob, which will introduce some bug.

after refactor
1. add to blob
2. create file record.

if 1 success but 2 failed just have a dirty blob in blob system, user
will not feel that



### Type of change


- [x] Refactoring
---
 api/apps/file_app.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/api/apps/file_app.py b/api/apps/file_app.py
index e06c9650c..eabe7bd9b 100644
--- a/api/apps/file_app.py
+++ b/api/apps/file_app.py
@@ -99,6 +99,7 @@ def upload():
                 FileService.query,
                 name=file_obj_names[file_len - 1],
                 parent_id=last_folder.id)
+            STORAGE_IMPL.put(last_folder.id, location, blob)
             file = {
                 "id": get_uuid(),
                 "parent_id": last_folder.id,
@@ -110,7 +111,6 @@ def upload():
                 "size": len(blob),
             }
             file = FileService.insert(file)
-            STORAGE_IMPL.put(last_folder.id, location, blob)
             file_res.append(file.to_json())
         return get_json_result(data=file_res)
     except Exception as e: