From a3fe879eba59b1ce65f2ab65893a263cd200549a Mon Sep 17 00:00:00 2001
From: Mike Fortman <michael.fortman@datastax.com>
Date: Tue, 30 Sep 2025 12:20:09 -0500
Subject: [PATCH] design feedback

---
 frontend/components/ui/switch.tsx     |  4 ++--
 frontend/src/app/settings/page.tsx    |  8 ++++----
 frontend/src/components/ui/switch.tsx | 29 ---------------------------
 3 files changed, 6 insertions(+), 35 deletions(-)
 delete mode 100644 frontend/src/components/ui/switch.tsx

diff --git a/frontend/components/ui/switch.tsx b/frontend/components/ui/switch.tsx
index 12187e8f..9d78fcfd 100644
--- a/frontend/components/ui/switch.tsx
+++ b/frontend/components/ui/switch.tsx
@@ -11,7 +11,7 @@ const Switch = React.forwardRef<
 >(({ className, ...props }, ref) => (
   <SwitchPrimitives.Root
     className={cn(
-      "peer inline-flex h-6 w-11 shrink-0 cursor-pointer items-center rounded-full border-2 border-transparent transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 focus-visible:ring-offset-background disabled:cursor-not-allowed disabled:opacity-50 data-[state=checked]:bg-primary data-[state=unchecked]:bg-input",
+      "peer inline-flex h-6 w-11 shrink-0 cursor-pointer items-center rounded-full border-2 border-transparent transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 focus-visible:ring-offset-background disabled:cursor-not-allowed disabled:opacity-50 data-[state=checked]:bg-primary data-[state=unchecked]:bg-muted",
       className
     )}
     {...props}
@@ -19,7 +19,7 @@ const Switch = React.forwardRef<
   >
     <SwitchPrimitives.Thumb
       className={cn(
-        "pointer-events-none block h-5 w-5 rounded-full bg-background shadow-lg ring-0 transition-transform data-[state=checked]:translate-x-5 data-[state=unchecked]:translate-x-0"
+        "pointer-events-none block h-5 w-5 rounded-full bg-background shadow-lg ring-0 transition-transform data-[state=checked]:translate-x-5 data-[state=unchecked]:translate-x-0 data-[state=unchecked]:bg-primary"
       )}
     />
   </SwitchPrimitives.Root>
diff --git a/frontend/src/app/settings/page.tsx b/frontend/src/app/settings/page.tsx
index 3e6ff092..cc439f53 100644
--- a/frontend/src/app/settings/page.tsx
+++ b/frontend/src/app/settings/page.tsx
@@ -1083,8 +1083,8 @@ function KnowledgeSourcesPage() {
                 </div>
               </div>
             </div>
-            <div className="space-y-3">
-              <div className="flex items-center justify-between">
+            <div className="">
+              <div className="flex items-center justify-between py-3 border-b border-border">
                 <div className="flex-1">
                   <Label
                     htmlFor="table-structure"
@@ -1102,7 +1102,7 @@ function KnowledgeSourcesPage() {
                   onCheckedChange={handleTableStructureChange}
                 />
               </div>
-              <div className="flex items-center justify-between">
+              <div className="flex items-center justify-between py-3 border-b border-border">
                 <div className="flex-1">
                   <Label
                     htmlFor="ocr"
@@ -1120,7 +1120,7 @@ function KnowledgeSourcesPage() {
                   onCheckedChange={handleOcrChange}
                 />
               </div>
-              <div className="flex items-center justify-between">
+              <div className="flex items-center justify-between py-3">
                 <div className="flex-1">
                   <Label
                     htmlFor="picture-descriptions"
diff --git a/frontend/src/components/ui/switch.tsx b/frontend/src/components/ui/switch.tsx
deleted file mode 100644
index b7f4d8a1..00000000
--- a/frontend/src/components/ui/switch.tsx
+++ /dev/null
@@ -1,29 +0,0 @@
-"use client"
-
-import * as React from "react"
-import * as SwitchPrimitives from "@radix-ui/react-switch"
-
-import { cn } from "@/lib/utils"
-
-const Switch = React.forwardRef<
-  React.ElementRef<typeof SwitchPrimitives.Root>,
-  React.ComponentPropsWithoutRef<typeof SwitchPrimitives.Root>
->(({ className, ...props }, ref) => (
-  <SwitchPrimitives.Root
-    className={cn(
-      "peer inline-flex h-6 w-11 shrink-0 cursor-pointer items-center rounded-full border-2 border-transparent transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 focus-visible:ring-offset-background disabled:cursor-not-allowed disabled:opacity-50 data-[state=checked]:bg-primary data-[state=unchecked]:bg-input",
-      className
-    )}
-    {...props}
-    ref={ref}
-  >
-    <SwitchPrimitives.Thumb
-      className={cn(
-        "pointer-events-none block h-5 w-5 rounded-full bg-background shadow-lg ring-0 transition-transform data-[state=checked]:translate-x-5 data-[state=unchecked]:translate-x-0"
-      )}
-    />
-  </SwitchPrimitives.Root>
-))
-Switch.displayName = SwitchPrimitives.Root.displayName
-
-export { Switch }
\ No newline at end of file