From 9928cba52128d0a58afc331e9950c258f272d26e Mon Sep 17 00:00:00 2001
From: Deon Sanchez <69873175+deon-sanchez@users.noreply.github.com>
Date: Thu, 18 Sep 2025 09:20:29 -0600
Subject: [PATCH] Refactor Knowledge Actions Dropdown and SearchPage Component

- Added TODO comments for implementing rename and sync functionalities in the KnowledgeActionsDropdown.
- Adjusted column definitions in the SearchPage component to improve layout with flex and minWidth properties.
- Commented out the sync button in the SearchPage for future implementation, enhancing code clarity.
---
 .../components/knowledge-actions-dropdown.tsx | 13 +++++++
 frontend/src/app/knowledge/page.tsx           | 35 +++++++++++++------
 2 files changed, 37 insertions(+), 11 deletions(-)

diff --git a/frontend/components/knowledge-actions-dropdown.tsx b/frontend/components/knowledge-actions-dropdown.tsx
index d4c0e6c0..9098adec 100644
--- a/frontend/components/knowledge-actions-dropdown.tsx
+++ b/frontend/components/knowledge-actions-dropdown.tsx
@@ -44,6 +44,19 @@ export const KnowledgeActionsDropdown = ({
           </Button>
         </DropdownMenuTrigger>
         <DropdownMenuContent side="right" sideOffset={-10}>
+          {/* //TODO: Implement rename and sync */}
+          {/* <DropdownMenuItem
+            className="text-primary focus:text-primary"
+            onClick={() => alert("Not implemented")}
+          >
+            Rename
+          </DropdownMenuItem>
+          <DropdownMenuItem
+            className="text-primary focus:text-primary"
+            onClick={() => alert("Not implemented")}
+          >
+            Sync
+          </DropdownMenuItem> */}
           <DropdownMenuItem
             className="text-destructive focus:text-destructive"
             onClick={() => setShowDeleteDialog(true)}
diff --git a/frontend/src/app/knowledge/page.tsx b/frontend/src/app/knowledge/page.tsx
index 0cd3c9f1..701b62c8 100644
--- a/frontend/src/app/knowledge/page.tsx
+++ b/frontend/src/app/knowledge/page.tsx
@@ -96,9 +96,11 @@ function SearchPage() {
       headerName: "Source",
       checkboxSelection: true,
       headerCheckboxSelection: true,
+      flex: 3,
+      minWidth: 200,
       cellRenderer: ({ data, value }: CustomCellRendererProps<File>) => {
         return (
-          <div className="flex items-center gap-2 ml-2">
+          <div className="flex items-center gap-2 ml-2 w-full">
             <div
               className="flex items-center gap-2 cursor-pointer hover:text-blue-600 transition-colors"
               onClick={e => {
@@ -122,30 +124,37 @@ function SearchPage() {
     {
       field: "size",
       headerName: "Size",
+      flex: 2,
+      minWidth: 80,
       valueFormatter: params =>
         params.value ? `${Math.round(params.value / 1024)} KB` : "-",
     },
     {
       field: "mimetype",
       headerName: "Type",
+      flex: 2,
+      minWidth: 80,
     },
     {
       field: "owner",
       headerName: "Owner",
+      flex: 2,
+      minWidth: 120,
       valueFormatter: params =>
-        params.value ||
-        params.data?.owner_name ||
-        params.data?.owner_email ||
-        "—",
+        params.data?.owner_name || params.data?.owner_email || "—",
     },
 
     {
       field: "chunkCount",
       headerName: "Chunks",
+      flex: 1,
+      minWidth: 70,
     },
     {
       field: "avgScore",
       headerName: "Avg score",
+      flex: 1,
+      minWidth: 90,
       cellRenderer: ({ value }: CustomCellRendererProps<File>) => {
         return (
           <span className="text-xs text-green-400 bg-green-400/20 px-2 py-1 rounded">
@@ -166,11 +175,12 @@ function SearchPage() {
       },
       colId: "actions",
       filter: false,
-      maxWidth: 60,
+      width: 60,
       minWidth: 60,
+      maxWidth: 60,
       resizable: false,
       sortable: false,
-      initialFlex: 0,
+      flex: 0,
     },
   ]);
 
@@ -179,8 +189,6 @@ function SearchPage() {
       display: "flex",
       alignItems: "center",
     }),
-    initialFlex: 1,
-    minWidth: 100,
     resizable: false,
     suppressMovable: true,
   };
@@ -269,14 +277,15 @@ function SearchPage() {
                 <Search className="h-4 w-4" />
               )}
             </Button>
-            <Button
+            {/* //TODO: Implement sync button */}
+            {/* <Button
               type="button"
               variant="outline"
               className="rounded-lg flex-shrink-0"
               onClick={() => alert("Not implemented")}
             >
               Sync
-            </Button>
+            </Button> */}
             <Button
               type="button"
               variant="destructive"
@@ -332,7 +341,9 @@ function SearchPage() {
               ))}
           </>
         ) : (
+          // <div className="w-full overflow-auto" style={{ maxWidth: "100%" }}>
           <AgGridReact
+            // className="w-full overflow-auto"
             columnDefs={columnDefs}
             defaultColDef={defaultColDef}
             loading={isFetching}
@@ -343,6 +354,7 @@ function SearchPage() {
             suppressRowClickSelection={false}
             getRowId={params => params.data.filename}
             onSelectionChanged={onSelectionChanged}
+            suppressHorizontalScroll={false}
             noRowsOverlayComponent={() => (
               <div className="text-center">
                 <Search className="h-12 w-12 mx-auto mb-4 text-muted-foreground/50" />
@@ -355,6 +367,7 @@ function SearchPage() {
               </div>
             )}
           />
+          // </div>
         )}
       </div>