gmakstutis/openrag
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

make name field required

Browse source
This commit is contained in:
Cole Goldsmith 2025-10-01 15:36:23 -05:00
parent a04454cbe2
commit 791bbdaef1
1 changed files with 23 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
frontend/components/knowledge-filter-panel.tsx
View file

@ -1,6 +1,6 @@
"use client"; "use client";
import { useState, useEffect } from "react"; import { useState, useEffect, useRef } from "react";
import { X, Save, RefreshCw } from "lucide-react"; import { X, Save, RefreshCw } from "lucide-react";
import { Button } from "@/components/ui/button"; import { Button } from "@/components/ui/button";
import { import {
@ -15,6 +15,7 @@ import { Label } from "@/components/ui/label";
import { Textarea } from "@/components/ui/textarea"; import { Textarea } from "@/components/ui/textarea";
import { MultiSelect } from "@/components/ui/multi-select"; import { MultiSelect } from "@/components/ui/multi-select";
import { Slider } from "@/components/ui/slider"; import { Slider } from "@/components/ui/slider";
import { cn } from "@/lib/utils";
import { useKnowledgeFilter } from "@/contexts/knowledge-filter-context"; import { useKnowledgeFilter } from "@/contexts/knowledge-filter-context";
import { useDeleteFilter } from "@/app/api/mutations/useDeleteFilter"; import { useDeleteFilter } from "@/app/api/mutations/useDeleteFilter";
import { useUpdateFilter } from "@/app/api/mutations/useUpdateFilter"; import { useUpdateFilter } from "@/app/api/mutations/useUpdateFilter";
@ -67,6 +68,8 @@ export function KnowledgeFilterPanel() {
const [isSaving, setIsSaving] = useState(false); const [isSaving, setIsSaving] = useState(false);
const [color, setColor] = useState<FilterColor>("zinc"); const [color, setColor] = useState<FilterColor>("zinc");
const [iconKey, setIconKey] = useState<IconKey>("filter"); const [iconKey, setIconKey] = useState<IconKey>("filter");
const [nameError, setNameError] = useState<string | null>(null);
const nameInputRef = useRef<HTMLInputElement>(null);
// Filter configuration states (mirror search page exactly) // Filter configuration states (mirror search page exactly)
const [query, setQuery] = useState(""); const [query, setQuery] = useState("");
@ -153,7 +156,11 @@ export function KnowledgeFilterPanel() {
if (!isPanelOpen || !parsedFilterData) return null; if (!isPanelOpen || !parsedFilterData) return null;
const handleSaveConfiguration = async () => { const handleSaveConfiguration = async () => {
if (!name.trim()) return; if (!name.trim()) {
setNameError("Name is required");
nameInputRef.current?.focus();
return;
}
const filterData = { const filterData = {
query, query,
filters: selectedFilters, filters: selectedFilters,
@ -247,7 +254,10 @@ export function KnowledgeFilterPanel() {
{/* Filter Name and Description */} {/* Filter Name and Description */}
<div className="space-y-3"> <div className="space-y-3">
<div className="space-y-2"> <div className="space-y-2">
<Label htmlFor="filter-name">Filter name</Label> <Label htmlFor="filter-name" className="gap-1">
Filter name
<span className="text-destructive">*</span>
</Label>
<div className="flex items-center gap-2"> <div className="flex items-center gap-2">
<FilterIconPopover <FilterIconPopover
color={color} color={color}
@ -258,8 +268,17 @@ export function KnowledgeFilterPanel() {
<Input <Input
id="filter-name" id="filter-name"
value={name} value={name}
onChange={(e) => setName(e.target.value)} onChange={(e) => {
const v = e.target.value;
setName(v);
if (nameError && v.trim()) {
setNameError(null);
}
}}
required
placeholder="Filter name" placeholder="Filter name"
ref={nameInputRef}
aria-invalid={!!nameError}
/> />
</div> </div>
</div> </div>