From 63bf4cad0f2e6ffcbabdd0cfaedcf8fec3ce8f40 Mon Sep 17 00:00:00 2001
From: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
Date: Mon, 8 Sep 2025 18:01:28 -0300
Subject: [PATCH] Refactor settings page to streamline state updates and remove
 unused interfaces

This commit simplifies the state update logic in the KnowledgeSourcesPage component by replacing multiple conditional assignments with concise if statements. Additionally, it removes unused GoogleDriveFile and OneDriveFile interfaces, enhancing code clarity and maintainability in line with best practices for async development.
---
 frontend/src/app/settings/page.tsx | 31 +++++-------------------------
 1 file changed, 5 insertions(+), 26 deletions(-)

diff --git a/frontend/src/app/settings/page.tsx b/frontend/src/app/settings/page.tsx
index 1c979fd7..48482a35 100644
--- a/frontend/src/app/settings/page.tsx
+++ b/frontend/src/app/settings/page.tsx
@@ -19,24 +19,6 @@ import { ProtectedRoute } from "@/components/protected-route";
 import { useTask } from "@/contexts/task-context";
 import { useAuth } from "@/contexts/auth-context";
 
-interface GoogleDriveFile {
-  id: string
-  name: string
-  mimeType: string
-  webViewLink?: string
-  iconLink?: string
-}
-
-interface OneDriveFile {
-  id: string
-  name: string
-  mimeType?: string
-  webUrl?: string
-  driveItem?: {
-    file?: { mimeType: string }
-    folder?: unknown
-  }
-}
 
 interface Connector {
 	id: string;
@@ -105,14 +87,11 @@ function KnowledgeSourcesPage() {
 			if (response.ok) {
 				const settings = await response.json();
 				// Update all state cleanly
-				settings.flow_id && setFlowId(settings.flow_id);
-				settings.ingest_flow_id && setIngestFlowId(settings.ingest_flow_id);
-				settings.langflow_edit_url &&
-					setLangflowEditUrl(settings.langflow_edit_url);
-				settings.langflow_ingest_edit_url &&
-					setLangflowIngestEditUrl(settings.langflow_ingest_edit_url);
-				settings.langflow_public_url &&
-					setPublicLangflowUrl(settings.langflow_public_url);
+				if (settings.flow_id) setFlowId(settings.flow_id);
+				if (settings.ingest_flow_id) setIngestFlowId(settings.ingest_flow_id);
+				if (settings.langflow_edit_url) setLangflowEditUrl(settings.langflow_edit_url);
+				if (settings.langflow_ingest_edit_url) setLangflowIngestEditUrl(settings.langflow_ingest_edit_url);
+				if (settings.langflow_public_url) setPublicLangflowUrl(settings.langflow_public_url);
 				if (settings.ingestion_defaults) {
 					console.log(
 						"Loading ingestion defaults from backend:",