75ca28acab
Fix all critical and high-priority issues from code review:
1. Fix checkout ref logic (CRITICAL)
- Simplified to: ref: ${{ inputs.tag || github.ref }}
- Works correctly for both workflow_dispatch and push events
- Removes conditional logic that would fail for manual triggers
2. Consolidate tag validation
- Remove duplicate validation logic
- Single validation path for both trigger types
- Clearer error messages with received value
3. Add PyPI error handling
- Use curl -sf for proper error codes
- Validate GRAPHITI_VERSION is not empty
- Exit with clear error if PyPI fetch fails
4. Improve docker-compose comments
- Add concrete version tag examples
- Show users how to pin specific versions
- Clarify when local build vs registry pull is used
5. Update workflow_dispatch description
- Clarify tag must already exist in repo
- Prevent user confusion about tag creation
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
|
||
|---|---|---|
| .. | ||
| ISSUE_TEMPLATE | ||
| workflows | ||
| dependabot.yml | ||
| pull_request_template.md | ||
| secret_scanning.yml | ||