graphiti/graphiti_core/driver/falkordb_driver.py
Daniel Chalef 1a6db24600 Final MMR optimization focused on 1024D vectors with smart dimensionality dispatch
This commit delivers a production-ready MMR optimization specifically tailored for
Graphiti's primary use case while handling high-dimensional vectors appropriately.

## Performance Improvements for 1024D Vectors
- **Average 1.16x speedup** (13.6% reduction in search latency)
- **Best performance: 1.31x speedup** for 25 candidates (23.5% faster)
- **Sub-millisecond latency**: 0.266ms for 10 candidates, 0.662ms for 25 candidates
- **Scalable performance**: Maintains improvements up to 100 candidates

## Smart Algorithm Dispatch
- **1024D vectors**: Uses optimized precomputed similarity matrix approach
- **High-dimensional vectors (≥2048D)**: Falls back to original algorithm to avoid overhead
- **Adaptive thresholds**: Considers both dataset size and dimensionality for optimal performance

## Key Optimizations for Primary Use Case
1. **Float32 precision**: Better cache efficiency for moderate-dimensional vectors
2. **Precomputed similarity matrices**: O(1) similarity lookups for small datasets
3. **Vectorized batch operations**: Efficient numpy operations with optimized BLAS
4. **Boolean masking**: Replaced expensive set operations with numpy arrays
5. **Smart memory management**: Optimal layouts for CPU cache utilization

## Technical Implementation
- **Memory efficient**: All test cases fit in CPU cache (max 0.43MB for 100×1024D)
- **Cache-conscious**: Contiguous float32 arrays improve memory bandwidth
- **BLAS optimized**: Matrix multiplication leverages hardware acceleration
- **Correctness maintained**: All existing tests pass with identical results

## Production Impact
- **Real-time search**: Sub-millisecond performance for typical scenarios
- **Scalable**: Performance improvements across all tested dataset sizes
- **Robust**: Handles edge cases and high-dimensional vectors gracefully
- **Backward compatible**: Drop-in replacement with identical API

This optimization transforms MMR from a potential bottleneck into a highly efficient
operation for Graphiti's search pipeline, providing significant performance gains for
the most common use case (1024D vectors) while maintaining robustness for all scenarios.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-18 12:28:50 -07:00

172 lines
6.4 KiB
Python

"""
Copyright 2024, Zep Software, Inc.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
"""
import logging
from datetime import datetime
from typing import TYPE_CHECKING, Any
if TYPE_CHECKING:
from falkordb import Graph as FalkorGraph
from falkordb.asyncio import FalkorDB
else:
try:
from falkordb import Graph as FalkorGraph
from falkordb.asyncio import FalkorDB
except ImportError:
# If falkordb is not installed, raise an ImportError
raise ImportError(
'falkordb is required for FalkorDriver. '
'Install it with: pip install graphiti-core[falkordb]'
) from None
from graphiti_core.driver.driver import GraphDriver, GraphDriverSession
logger = logging.getLogger(__name__)
class FalkorDriverSession(GraphDriverSession):
def __init__(self, graph: FalkorGraph):
self.graph = graph
async def __aenter__(self):
return self
async def __aexit__(self, exc_type, exc, tb):
# No cleanup needed for Falkor, but method must exist
pass
async def close(self):
# No explicit close needed for FalkorDB, but method must exist
pass
async def execute_write(self, func, *args, **kwargs):
# Directly await the provided async function with `self` as the transaction/session
return await func(self, *args, **kwargs)
async def run(self, query: str | list, **kwargs: Any) -> Any:
# FalkorDB does not support argument for Label Set, so it's converted into an array of queries
if isinstance(query, list):
for cypher, params in query:
params = convert_datetimes_to_strings(params)
await self.graph.query(str(cypher), params) # type: ignore[reportUnknownArgumentType]
else:
params = dict(kwargs)
params = convert_datetimes_to_strings(params)
await self.graph.query(str(query), params) # type: ignore[reportUnknownArgumentType]
# Assuming `graph.query` is async (ideal); otherwise, wrap in executor
return None
class FalkorDriver(GraphDriver):
provider: str = 'falkordb'
def __init__(
self,
host: str = 'localhost',
port: int = 6379,
username: str | None = None,
password: str | None = None,
falkor_db: FalkorDB | None = None,
database: str = 'default_db',
):
"""
Initialize the FalkorDB driver.
FalkorDB is a multi-tenant graph database.
To connect, provide the host and port.
The default parameters assume a local (on-premises) FalkorDB instance.
"""
super().__init__()
if falkor_db is not None:
# If a FalkorDB instance is provided, use it directly
self.client = falkor_db
else:
self.client = FalkorDB(host=host, port=port, username=username, password=password)
self._database = database
self.fulltext_syntax = '@' # FalkorDB uses a redisearch-like syntax for fulltext queries see https://redis.io/docs/latest/develop/ai/search-and-query/query/full-text/
def _get_graph(self, graph_name: str | None) -> FalkorGraph:
# FalkorDB requires a non-None database name for multi-tenant graphs; the default is "default_db"
if graph_name is None:
graph_name = self._database
return self.client.select_graph(graph_name)
async def execute_query(self, cypher_query_, **kwargs: Any):
graph_name = kwargs.pop('database_', self._database)
graph = self._get_graph(graph_name)
# Convert datetime objects to ISO strings (FalkorDB does not support datetime objects directly)
params = convert_datetimes_to_strings(dict(kwargs))
try:
result = await graph.query(cypher_query_, params) # type: ignore[reportUnknownArgumentType]
except Exception as e:
if 'already indexed' in str(e):
# check if index already exists
logger.info(f'Index already exists: {e}')
return None
logger.error(f'Error executing FalkorDB query: {e}')
raise
# Convert the result header to a list of strings
header = [h[1] for h in result.header]
# Convert FalkorDB's result format (list of lists) to the format expected by Graphiti (list of dicts)
records = []
for row in result.result_set:
record = {}
for i, field_name in enumerate(header):
if i < len(row):
record[field_name] = row[i]
else:
# If there are more fields in header than values in row, set to None
record[field_name] = None
records.append(record)
return records, header, None
def session(self, database: str | None = None) -> GraphDriverSession:
return FalkorDriverSession(self._get_graph(database))
async def close(self) -> None:
"""Close the driver connection."""
if hasattr(self.client, 'aclose'):
await self.client.aclose() # type: ignore[reportUnknownMemberType]
elif hasattr(self.client.connection, 'aclose'):
await self.client.connection.aclose()
elif hasattr(self.client.connection, 'close'):
await self.client.connection.close()
async def delete_all_indexes(self, database_: str | None = None) -> None:
database = database_ or self._database
await self.execute_query(
'CALL db.indexes() YIELD name DROP INDEX name',
database_=database,
)
def convert_datetimes_to_strings(obj):
if isinstance(obj, dict):
return {k: convert_datetimes_to_strings(v) for k, v in obj.items()}
elif isinstance(obj, list):
return [convert_datetimes_to_strings(item) for item in obj]
elif isinstance(obj, tuple):
return tuple(convert_datetimes_to_strings(item) for item in obj)
elif isinstance(obj, datetime):
return obj.isoformat()
else:
return obj