Daniel Chalef
|
671ffe9cc8
|
fix: Comprehensive MCP server fixes and configuration consolidation
## Critical Fixes
### 🔧 FalkorDB Support Implementation
- Fixed incomplete FalkorDB support in `factories.py:276`
- Replaced `NotImplementedError` with proper configuration mapping
- FalkorDB now returns valid config dict with uri, password, database fields
### ⚙️ Configuration System Consolidation
- **REMOVED dual configuration systems** - eliminated config inconsistency
- Deleted obsolete files: `config/manager.py`, `config/server_config.py`
- Deleted unused individual configs: `llm_config.py`, `embedder_config.py`, `neo4j_config.py`
- **Unified all configuration** through `config/schema.py`
- Updated imports: `MCPConfig` → `ServerConfig` from schema
- Added missing fields (`use_custom_entities`, `destroy_graph`) to main config
### 🔄 Environment Variable Handling
- **Eliminated duplicate environment variable patterns** across modules
- Consolidated all env handling into single schema-based system
- Removed redundant `from_env()` methods in individual config classes
- All environment variables now handled through pydantic-settings in schema.py
### 🔒 Security Improvements - GitHub Actions
- **Added proper permissions** to both workflow files:
- `contents: read` - Minimal read access to repository
- `id-token: write` - Secure token handling for OIDC
- Follows security best practices for CI/CD workflows
- Prevents overprivileged workflow execution
### 🧪 Test Infrastructure Updates
- Updated validation test file list for new structure
- Fixed test execution path issues with uv detection
- Improved error handling in startup tests
- All syntax validation now passes (8/8 files)
## Verification
✅ **All systems tested and working**:
- Configuration loading and CLI overrides functional
- Import structure validated across all modules
- Main.py wrapper maintains backwards compatibility
- FalkorDB configuration no longer raises NotImplementedError
- GitHub Actions have secure permissions
- No duplicate environment variable handling
## Benefits
- **Simplified Architecture**: Single source of truth for configuration
- **Enhanced Security**: Proper workflow permissions implemented
- **Complete FalkorDB Support**: No more unimplemented features
- **Maintainable Codebase**: Eliminated configuration duplication
- **Secure CI/CD**: Minimal required permissions only
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
|
2025-08-30 08:50:48 -07:00 |
|
Daniel Chalef
|
3c25268afc
|
feat: Major MCP server refactor with improved structure and CI/CD
- Reorganized MCP server into clean, scalable directory structure:
- `src/config/` - Configuration modules (schema, managers, provider configs)
- `src/services/` - Services (queue, factories)
- `src/models/` - Data models (entities, responses)
- `src/utils/` - Utilities (formatting, helpers)
- `tests/` - All test files
- `config/` - Configuration files (YAML, examples)
- `docker/` - Docker setup files
- `docs/` - Documentation
- Added `main.py` wrapper for seamless transition
- Maintains existing command-line interface
- All deployment scripts continue to work unchanged
- **Queue Service Interface Fix**: Fixed missing `add_episode()` and `initialize()` methods
- Server calls at `graphiti_mcp_server.py:276` and `:755` now work correctly
- Eliminates runtime crashes on startup and episode processing
- Updated imports throughout restructured codebase
- Fixed Python module name conflicts (renamed `types/` to `models/`)
- **MCP Server Tests Action** (`.github/workflows/mcp-server-tests.yml`)
- Runs on PRs targeting main with `mcp_server/**` changes
- Configuration validation, syntax checking, unit tests
- Import structure validation, dependency verification
- Main.py wrapper functionality testing
- **MCP Server Lint Action** (`.github/workflows/mcp-server-lint.yml`)
- Code formatting with ruff (100 char line length, single quotes)
- Comprehensive linting with GitHub-formatted output
- Type checking with pyright (baseline approach for existing errors)
- Import sorting validation
- Added ruff and pyright configuration to `mcp_server/pyproject.toml`
- Proper tool configuration for the new structure
- Enhanced development dependencies with formatting/linting tools
- All existing tests moved and updated for new structure
- Import paths updated throughout test suite
- Validation scripts enhanced for restructured codebase
- **Improved Maintainability**: Clear separation of concerns
- **Better Scalability**: Organized structure supports growth
- **Enhanced Developer Experience**: Proper linting, formatting, type checking
- **Automated Quality Gates**: CI/CD ensures code quality on every PR
- **Zero Breaking Changes**: Maintains full backwards compatibility
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
|
2025-08-30 08:50:48 -07:00 |
|