From 46771eb90b87e080948ae61223c2d1be99752b30 Mon Sep 17 00:00:00 2001 From: Daniel Chalef <131175+danielchalef@users.noreply.github.com> Date: Mon, 29 Sep 2025 21:15:13 -0700 Subject: [PATCH] refactor: Clean up test_edge_operations.py and format response returns - Remove unnecessary stubs for opensearchpy module. - Format return values in llm_client.generate_response for consistency. - Enhance readability by ensuring proper indentation and structure in test cases. This refactor improves the clarity and maintainability of the test suite for edge operations. --- .../utils/maintenance/test_edge_operations.py | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/tests/utils/maintenance/test_edge_operations.py b/tests/utils/maintenance/test_edge_operations.py index 188defca..5dc05798 100644 --- a/tests/utils/maintenance/test_edge_operations.py +++ b/tests/utils/maintenance/test_edge_operations.py @@ -1,14 +1,7 @@ -import sys -import types from datetime import datetime, timedelta, timezone from types import SimpleNamespace from unittest.mock import AsyncMock, MagicMock -opensearch_stub = types.ModuleType('opensearchpy') -opensearch_stub.AsyncOpenSearch = None -opensearch_stub.helpers = None -sys.modules.setdefault('opensearchpy', opensearch_stub) - import pytest from pydantic import BaseModel @@ -179,7 +172,11 @@ async def test_resolve_extracted_edges_resets_unmapped_names(monkeypatch): llm_client = MagicMock() llm_client.generate_response = AsyncMock( - return_value={'duplicate_facts': [], 'contradicted_facts': [], 'fact_type': 'DEFAULT'} + return_value={ + 'duplicate_facts': [], + 'contradicted_facts': [], + 'fact_type': 'DEFAULT', + } ) clients = SimpleNamespace( @@ -256,7 +253,11 @@ async def test_resolve_extracted_edges_keeps_unknown_names(monkeypatch): llm_client = MagicMock() llm_client.generate_response = AsyncMock( - return_value={'duplicate_facts': [], 'contradicted_facts': [], 'fact_type': 'DEFAULT'} + return_value={ + 'duplicate_facts': [], + 'contradicted_facts': [], + 'fact_type': 'DEFAULT', + } ) clients = SimpleNamespace(