From 1b54b4514495180ba9e350913fc1deff2eb8e387 Mon Sep 17 00:00:00 2001
From: Daniel Chalef <131175+danielchalef@users.noreply.github.com>
Date: Wed, 21 May 2025 20:32:18 -0700
Subject: [PATCH] Improve error handling in GeminiEmbedder by raising
 ValueError for empty embedding values. This change enhances robustness by
 ensuring that all returned embeddings contain valid data. (#515)

---
 graphiti_core/embedder/gemini.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/graphiti_core/embedder/gemini.py b/graphiti_core/embedder/gemini.py
index d83f71c7..a45e3957 100644
--- a/graphiti_core/embedder/gemini.py
+++ b/graphiti_core/embedder/gemini.py
@@ -81,4 +81,9 @@ class GeminiEmbedder(EmbedderClient):
         if not result.embeddings or len(result.embeddings) == 0:
             raise Exception('No embeddings returned')
 
-        return [embedding.values if embedding.values else [] for embedding in result.embeddings]
+        embeddings = []
+        for embedding in result.embeddings:
+            if not embedding.values:
+                raise ValueError('Empty embedding values returned')
+            embeddings.append(embedding.values)
+        return embeddings