14d9540d1b
<!-- .github/pull_request_template.md -->
## Description
- Add support for database deletion when dataset is deleted
- Simplify dataset handler usage in Cognee
## Type of Change
<!-- Please check the relevant option -->
- [x] Bug fix (non-breaking change that fixes an issue)
- [ ] New feature (non-breaking change that adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Documentation update
- [ ] Code refactoring
- [ ] Performance improvement
- [ ] Other (please specify):
## Screenshots/Videos (if applicable)
<!-- Add screenshots or videos to help explain your changes -->
## Pre-submission Checklist
<!-- Please check all boxes that apply before submitting your PR -->
- [ ] **I have tested my changes thoroughly before submitting this PR**
- [ ] **This PR contains minimal changes necessary to address the
issue/feature**
- [ ] My code follows the project's coding standards and style
guidelines
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have added necessary documentation (if applicable)
- [ ] All new and existing tests pass
- [ ] I have searched existing PRs to ensure this change hasn't been
submitted already
- [ ] I have linked any relevant issues in the description
- [ ] My commits have clear and descriptive messages
## DCO Affirmation
I affirm that all code in every commit of this pull request conforms to
the terms of the Topoteretes Developer Certificate of Origin.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Bug Fixes**
* Improved dataset deletion: stronger authorization checks and reliable
removal of associated graph and vector storage.
* **Tests**
* Added end-to-end test to verify complete dataset deletion and cleanup
of all related storage components.
<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
30 lines
1.3 KiB
Python
30 lines
1.3 KiB
Python
from cognee.infrastructure.databases.utils.get_graph_dataset_database_handler import (
|
|
get_graph_dataset_database_handler,
|
|
)
|
|
from cognee.infrastructure.databases.utils.get_vector_dataset_database_handler import (
|
|
get_vector_dataset_database_handler,
|
|
)
|
|
from cognee.modules.users.models.DatasetDatabase import DatasetDatabase
|
|
|
|
|
|
async def resolve_dataset_database_connection_info(
|
|
dataset_database: DatasetDatabase,
|
|
) -> DatasetDatabase:
|
|
"""
|
|
Resolve the connection info for the given DatasetDatabase instance.
|
|
Resolve both vector and graph database connection info and return the updated DatasetDatabase instance.
|
|
|
|
Args:
|
|
dataset_database: DatasetDatabase instance
|
|
Returns:
|
|
DatasetDatabase instance with resolved connection info
|
|
"""
|
|
vector_dataset_database_handler = get_vector_dataset_database_handler(dataset_database)
|
|
graph_dataset_database_handler = get_graph_dataset_database_handler(dataset_database)
|
|
dataset_database = await vector_dataset_database_handler[
|
|
"handler_instance"
|
|
].resolve_dataset_connection_info(dataset_database)
|
|
dataset_database = await graph_dataset_database_handler[
|
|
"handler_instance"
|
|
].resolve_dataset_connection_info(dataset_database)
|
|
return dataset_database
|