gmakstutis/cognee
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: handle newlines explicitly when storing files

Browse source
This commit is contained in:
Daulet Amirkhanov 2025-10-22 19:34:37 +01:00
parent c7d0f64cb1
commit eee39b238b
2 changed files with 20 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
cognee/infrastructure/files/storage/LocalFileStorage.py
View file

@ -82,16 +82,16 @@ class LocalFileStorage(Storage):
self.ensure_directory_exists(file_dir_path) self.ensure_directory_exists(file_dir_path)
if overwrite or not os.path.exists(full_file_path): if overwrite or not os.path.exists(full_file_path):
with open( if isinstance(data, str):
full_file_path, with open(full_file_path, mode="w", encoding="utf-8", newline="\n") as file:
mode="w" if isinstance(data, str) else "wb",
encoding="utf-8" if isinstance(data, str) else None,
) as file:
if hasattr(data, "read"):
data.seek(0)
file.write(data.read())
else:
file.write(data) file.write(data)
else:
with open(full_file_path, mode="wb") as file:
if hasattr(data, "read"):
data.seek(0)
file.write(data.read())
else:
file.write(data)
file.close() file.close()

22
cognee/infrastructure/files/storage/S3FileStorage.py
View file

@ -70,18 +70,18 @@ class S3FileStorage(Storage):
if overwrite or not await self.file_exists(file_path): if overwrite or not await self.file_exists(file_path):
def save_data_to_file(): def save_data_to_file():
with self.s3.open( if isinstance(data, str):
full_file_path, with self.s3.open(
mode="w" if isinstance(data, str) else "wb", full_file_path, mode="w", encoding="utf-8", newline="\n"
encoding="utf-8" if isinstance(data, str) else None, ) as file:
) as file:
if hasattr(data, "read"):
data.seek(0)
file.write(data.read())
else:
file.write(data) file.write(data)
else:
file.close() with self.s3.open(full_file_path, mode="wb") as file:
if hasattr(data, "read"):
data.seek(0)
file.write(data.read())
else:
file.write(data)
await run_async(save_data_to_file) await run_async(save_data_to_file)