refactor: default to none as observability to avoid Langfuse key warning (#1440)
<!-- .github/pull_request_template.md --> ## Description <!-- Please provide a clear, human-generated description of the changes in this PR. DO NOT use AI-generated descriptions. We want to understand your thought process and reasoning. --> ## Type of Change <!-- Please check the relevant option --> - [x] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Code refactoring - [ ] Performance improvement - [ ] Other (please specify): ## Changes Made <!-- List the specific changes made in this PR --> - - - ## Testing <!-- Describe how you tested your changes --> ## Screenshots/Videos (if applicable) <!-- Add screenshots or videos to help explain your changes --> ## Pre-submission Checklist <!-- Please check all boxes that apply before submitting your PR --> - [ ] **I have tested my changes thoroughly before submitting this PR** - [ ] **This PR contains minimal changes necessary to address the issue/feature** - [ ] My code follows the project's coding standards and style guidelines - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if applicable) - [ ] All new and existing tests pass - [ ] I have searched existing PRs to ensure this change hasn't been submitted already - [ ] I have linked any relevant issues in the description - [ ] My commits have clear and descriptive messages ## Related Issues <!-- Link any related issues using "Fixes #issue_number" or "Relates to #issue_number" --> ## Additional Notes <!-- Add any additional notes, concerns, or context for reviewers --> ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.
This commit is contained in:
commit
e79f7a9aef
3 changed files with 21 additions and 2 deletions
|
|
@ -11,7 +11,8 @@ class BaseConfig(BaseSettings):
|
||||||
data_root_directory: str = get_absolute_path(".data_storage")
|
data_root_directory: str = get_absolute_path(".data_storage")
|
||||||
system_root_directory: str = get_absolute_path(".cognee_system")
|
system_root_directory: str = get_absolute_path(".cognee_system")
|
||||||
cache_root_directory: str = get_absolute_path(".cognee_cache")
|
cache_root_directory: str = get_absolute_path(".cognee_cache")
|
||||||
monitoring_tool: object = Observer.LANGFUSE
|
monitoring_tool: object = Observer.NONE
|
||||||
|
|
||||||
|
|
||||||
@pydantic.model_validator(mode="after")
|
@pydantic.model_validator(mode="after")
|
||||||
def validate_paths(self):
|
def validate_paths(self):
|
||||||
|
|
@ -30,7 +31,10 @@ class BaseConfig(BaseSettings):
|
||||||
# Require absolute paths for root directories
|
# Require absolute paths for root directories
|
||||||
self.data_root_directory = ensure_absolute_path(self.data_root_directory)
|
self.data_root_directory = ensure_absolute_path(self.data_root_directory)
|
||||||
self.system_root_directory = ensure_absolute_path(self.system_root_directory)
|
self.system_root_directory = ensure_absolute_path(self.system_root_directory)
|
||||||
self.cache_root_directory = ensure_absolute_path(self.cache_root_directory)
|
# Set monitoring tool based on available keys
|
||||||
|
if self.langfuse_public_key and self.langfuse_secret_key:
|
||||||
|
self.monitoring_tool = Observer.LANGFUSE
|
||||||
|
|
||||||
return self
|
return self
|
||||||
|
|
||||||
langfuse_public_key: Optional[str] = os.getenv("LANGFUSE_PUBLIC_KEY")
|
langfuse_public_key: Optional[str] = os.getenv("LANGFUSE_PUBLIC_KEY")
|
||||||
|
|
|
||||||
|
|
@ -9,3 +9,17 @@ def get_observe():
|
||||||
from langfuse.decorators import observe
|
from langfuse.decorators import observe
|
||||||
|
|
||||||
return observe
|
return observe
|
||||||
|
elif monitoring == Observer.NONE:
|
||||||
|
# Return a no-op decorator that handles keyword arguments
|
||||||
|
def no_op_decorator(*args, **kwargs):
|
||||||
|
if len(args) == 1 and callable(args[0]) and not kwargs:
|
||||||
|
# Direct decoration: @observe
|
||||||
|
return args[0]
|
||||||
|
else:
|
||||||
|
# Parameterized decoration: @observe(as_type="generation")
|
||||||
|
def decorator(func):
|
||||||
|
return func
|
||||||
|
|
||||||
|
return decorator
|
||||||
|
|
||||||
|
return no_op_decorator
|
||||||
|
|
|
||||||
|
|
@ -4,6 +4,7 @@ from enum import Enum
|
||||||
class Observer(str, Enum):
|
class Observer(str, Enum):
|
||||||
"""Monitoring tools"""
|
"""Monitoring tools"""
|
||||||
|
|
||||||
|
NONE = "none"
|
||||||
LANGFUSE = "langfuse"
|
LANGFUSE = "langfuse"
|
||||||
LLMLITE = "llmlite"
|
LLMLITE = "llmlite"
|
||||||
LANGSMITH = "langsmith"
|
LANGSMITH = "langsmith"
|
||||||
|
|
|
||||||
Loading…
Add table
Reference in a new issue