From c62800c2f076313cd2ed7329d2a0e971e8b1b947 Mon Sep 17 00:00:00 2001 From: Leon Luithlen Date: Fri, 8 Nov 2024 14:26:20 +0100 Subject: [PATCH 1/3] Remove automatic execution of test that require LLM inputs from merge requests onto main --- .github/workflows/test_neo4j.yml | 3 --- .github/workflows/test_notebook.yml | 3 --- .github/workflows/test_pgvector.yml | 3 --- .github/workflows/test_qdrant.yml | 3 --- .github/workflows/test_weaviate.yml | 3 --- 5 files changed, 15 deletions(-) diff --git a/.github/workflows/test_neo4j.yml b/.github/workflows/test_neo4j.yml index 47d928fd9..88cd1b7ce 100644 --- a/.github/workflows/test_neo4j.yml +++ b/.github/workflows/test_neo4j.yml @@ -1,9 +1,6 @@ name: test | neo4j on: - pull_request: - branches: - - main workflow_dispatch: concurrency: diff --git a/.github/workflows/test_notebook.yml b/.github/workflows/test_notebook.yml index 5e57ada02..fb9648e1f 100644 --- a/.github/workflows/test_notebook.yml +++ b/.github/workflows/test_notebook.yml @@ -1,9 +1,6 @@ name: test | notebook on: - pull_request: - branches: - - main workflow_dispatch: concurrency: diff --git a/.github/workflows/test_pgvector.yml b/.github/workflows/test_pgvector.yml index 913d249e2..062a35b54 100644 --- a/.github/workflows/test_pgvector.yml +++ b/.github/workflows/test_pgvector.yml @@ -1,9 +1,6 @@ name: test | pgvector on: - pull_request: - branches: - - main workflow_dispatch: concurrency: diff --git a/.github/workflows/test_qdrant.yml b/.github/workflows/test_qdrant.yml index af9f66257..1562619b0 100644 --- a/.github/workflows/test_qdrant.yml +++ b/.github/workflows/test_qdrant.yml @@ -1,9 +1,6 @@ name: test | qdrant on: - pull_request: - branches: - - main workflow_dispatch: concurrency: diff --git a/.github/workflows/test_weaviate.yml b/.github/workflows/test_weaviate.yml index cbdd28cef..0b8d8e1ac 100644 --- a/.github/workflows/test_weaviate.yml +++ b/.github/workflows/test_weaviate.yml @@ -1,9 +1,6 @@ name: test | weaviate on: - pull_request: - branches: - - main workflow_dispatch: concurrency: From c2dfe25ef27de2910092306196a708e56b231f33 Mon Sep 17 00:00:00 2001 From: Leon Luithlen Date: Fri, 8 Nov 2024 14:44:49 +0100 Subject: [PATCH 2/3] Try run-checks approach --- .github/workflows/test_neo4j.yml | 6 ++++++ .github/workflows/test_notebook.yml | 7 +++++++ .github/workflows/test_pgvector.yml | 7 +++++++ .github/workflows/test_qdrant.yml | 7 +++++++ .github/workflows/test_weaviate.yml | 7 +++++++ 5 files changed, 34 insertions(+) diff --git a/.github/workflows/test_neo4j.yml b/.github/workflows/test_neo4j.yml index 88cd1b7ce..25e1c0f38 100644 --- a/.github/workflows/test_neo4j.yml +++ b/.github/workflows/test_neo4j.yml @@ -2,6 +2,10 @@ name: test | neo4j on: workflow_dispatch: + pull_request: + branches: + - main + types: [labeled] concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} @@ -11,6 +15,8 @@ env: RUNTIME__LOG_LEVEL: ERROR jobs: + if: ${{ github.event.label.name == 'run-checks' }} + get_docs_changes: name: docs changes uses: ./.github/workflows/get_docs_changes.yml diff --git a/.github/workflows/test_notebook.yml b/.github/workflows/test_notebook.yml index fb9648e1f..24b766eca 100644 --- a/.github/workflows/test_notebook.yml +++ b/.github/workflows/test_notebook.yml @@ -2,6 +2,11 @@ name: test | notebook on: workflow_dispatch: + pull_request: + branches: + - main + types: [labeled] + concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} @@ -11,6 +16,8 @@ env: RUNTIME__LOG_LEVEL: ERROR jobs: + if: ${{ github.event.label.name == 'run-checks' }} + get_docs_changes: name: docs changes uses: ./.github/workflows/get_docs_changes.yml diff --git a/.github/workflows/test_pgvector.yml b/.github/workflows/test_pgvector.yml index 062a35b54..5ba149a19 100644 --- a/.github/workflows/test_pgvector.yml +++ b/.github/workflows/test_pgvector.yml @@ -2,6 +2,11 @@ name: test | pgvector on: workflow_dispatch: + pull_request: + branches: + - main + types: [labeled] + concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} @@ -11,6 +16,8 @@ env: RUNTIME__LOG_LEVEL: ERROR jobs: + if: ${{ github.event.label.name == 'run-checks' }} + get_docs_changes: name: docs changes uses: ./.github/workflows/get_docs_changes.yml diff --git a/.github/workflows/test_qdrant.yml b/.github/workflows/test_qdrant.yml index 1562619b0..b78e21f31 100644 --- a/.github/workflows/test_qdrant.yml +++ b/.github/workflows/test_qdrant.yml @@ -2,6 +2,11 @@ name: test | qdrant on: workflow_dispatch: + pull_request: + branches: + - main + types: [labeled] + concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} @@ -11,6 +16,8 @@ env: RUNTIME__LOG_LEVEL: ERROR jobs: + if: ${{ github.event.label.name == 'run-checks' }} + get_docs_changes: name: docs changes uses: ./.github/workflows/get_docs_changes.yml diff --git a/.github/workflows/test_weaviate.yml b/.github/workflows/test_weaviate.yml index 0b8d8e1ac..05d841725 100644 --- a/.github/workflows/test_weaviate.yml +++ b/.github/workflows/test_weaviate.yml @@ -2,6 +2,11 @@ name: test | weaviate on: workflow_dispatch: + pull_request: + branches: + - main + types: [labeled] + concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} @@ -11,6 +16,8 @@ env: RUNTIME__LOG_LEVEL: ERROR jobs: + if: ${{ github.event.label.name == 'run-checks' }} + get_docs_changes: name: docs changes uses: ./.github/workflows/get_docs_changes.yml From 236a8c1d3fafee172eb60e2130341649037411b7 Mon Sep 17 00:00:00 2001 From: Leon Luithlen Date: Fri, 8 Nov 2024 14:51:08 +0100 Subject: [PATCH 3/3] Move github actions if condition --- .github/workflows/test_neo4j.yml | 4 +--- .github/workflows/test_notebook.yml | 4 +--- .github/workflows/test_pgvector.yml | 4 +--- .github/workflows/test_qdrant.yml | 4 +--- .github/workflows/test_weaviate.yml | 4 +--- 5 files changed, 5 insertions(+), 15 deletions(-) diff --git a/.github/workflows/test_neo4j.yml b/.github/workflows/test_neo4j.yml index 25e1c0f38..55b0f4ee4 100644 --- a/.github/workflows/test_neo4j.yml +++ b/.github/workflows/test_neo4j.yml @@ -15,8 +15,6 @@ env: RUNTIME__LOG_LEVEL: ERROR jobs: - if: ${{ github.event.label.name == 'run-checks' }} - get_docs_changes: name: docs changes uses: ./.github/workflows/get_docs_changes.yml @@ -24,7 +22,7 @@ jobs: run_neo4j_integration_test: name: test needs: get_docs_changes - if: needs.get_docs_changes.outputs.changes_outside_docs == 'true' + if: needs.get_docs_changes.outputs.changes_outside_docs == 'true' | ${{ github.event.label.name == 'run-checks' }} runs-on: ubuntu-latest defaults: diff --git a/.github/workflows/test_notebook.yml b/.github/workflows/test_notebook.yml index 24b766eca..20f51a6e2 100644 --- a/.github/workflows/test_notebook.yml +++ b/.github/workflows/test_notebook.yml @@ -16,8 +16,6 @@ env: RUNTIME__LOG_LEVEL: ERROR jobs: - if: ${{ github.event.label.name == 'run-checks' }} - get_docs_changes: name: docs changes uses: ./.github/workflows/get_docs_changes.yml @@ -25,7 +23,7 @@ jobs: run_notebook_test: name: test needs: get_docs_changes - if: needs.get_docs_changes.outputs.changes_outside_docs == 'true' + if: needs.get_docs_changes.outputs.changes_outside_docs == 'true' | ${{ github.event.label.name == 'run-checks' }} runs-on: ubuntu-latest defaults: run: diff --git a/.github/workflows/test_pgvector.yml b/.github/workflows/test_pgvector.yml index 5ba149a19..c9dfc2c35 100644 --- a/.github/workflows/test_pgvector.yml +++ b/.github/workflows/test_pgvector.yml @@ -16,8 +16,6 @@ env: RUNTIME__LOG_LEVEL: ERROR jobs: - if: ${{ github.event.label.name == 'run-checks' }} - get_docs_changes: name: docs changes uses: ./.github/workflows/get_docs_changes.yml @@ -25,7 +23,7 @@ jobs: run_pgvector_integration_test: name: test needs: get_docs_changes - if: needs.get_docs_changes.outputs.changes_outside_docs == 'true' + if: needs.get_docs_changes.outputs.changes_outside_docs == 'true' | ${{ github.event.label.name == 'run-checks' }} runs-on: ubuntu-latest defaults: run: diff --git a/.github/workflows/test_qdrant.yml b/.github/workflows/test_qdrant.yml index b78e21f31..595325672 100644 --- a/.github/workflows/test_qdrant.yml +++ b/.github/workflows/test_qdrant.yml @@ -16,8 +16,6 @@ env: RUNTIME__LOG_LEVEL: ERROR jobs: - if: ${{ github.event.label.name == 'run-checks' }} - get_docs_changes: name: docs changes uses: ./.github/workflows/get_docs_changes.yml @@ -25,7 +23,7 @@ jobs: run_qdrant_integration_test: name: test needs: get_docs_changes - if: needs.get_docs_changes.outputs.changes_outside_docs == 'true' + if: needs.get_docs_changes.outputs.changes_outside_docs == 'true' | ${{ github.event.label.name == 'run-checks' }} runs-on: ubuntu-latest defaults: diff --git a/.github/workflows/test_weaviate.yml b/.github/workflows/test_weaviate.yml index 05d841725..9353d1747 100644 --- a/.github/workflows/test_weaviate.yml +++ b/.github/workflows/test_weaviate.yml @@ -16,8 +16,6 @@ env: RUNTIME__LOG_LEVEL: ERROR jobs: - if: ${{ github.event.label.name == 'run-checks' }} - get_docs_changes: name: docs changes uses: ./.github/workflows/get_docs_changes.yml @@ -25,7 +23,7 @@ jobs: run_weaviate_integration_test: name: test needs: get_docs_changes - if: needs.get_docs_changes.outputs.changes_outside_docs == 'true' + if: needs.get_docs_changes.outputs.changes_outside_docs == 'true' | ${{ github.event.label.name == 'run-checks' }} runs-on: ubuntu-latest defaults: