refactor: remove redundant filestream arg from LoaderEngine.load_file(...)

This commit is contained in:
Daulet Amirkhanov 2025-10-17 16:54:27 +01:00
parent a69a7e5fc4
commit a0f760a3d1

View file

@ -50,17 +50,17 @@ async def data_item_to_text_file(
await pull_from_s3(data_item_path, temp_file)
temp_file.flush() # Data needs to be saved to local storage
loader = get_loader_engine()
return await loader.load_file(
temp_file.name, None, preferred_loaders
), loader.get_loader(temp_file.name, preferred_loaders)
return await loader.load_file(temp_file.name, preferred_loaders), loader.get_loader(
temp_file.name, preferred_loaders
)
# data is local file path
elif parsed_url.scheme == "file":
if settings.accept_local_file_path:
loader = get_loader_engine()
return await loader.load_file(
data_item_path, None, preferred_loaders
), loader.get_loader(data_item_path, preferred_loaders)
return await loader.load_file(data_item_path, preferred_loaders), loader.get_loader(
data_item_path, preferred_loaders
)
else:
raise IngestionError(message="Local files are not accepted.")
@ -71,9 +71,9 @@ async def data_item_to_text_file(
# Handle both Unix absolute paths (/path) and Windows absolute paths (C:\path)
if settings.accept_local_file_path:
loader = get_loader_engine()
return await loader.load_file(
data_item_path, None, preferred_loaders
), loader.get_loader(data_item_path, preferred_loaders)
return await loader.load_file(data_item_path, preferred_loaders), loader.get_loader(
data_item_path, preferred_loaders
)
else:
raise IngestionError(message="Local files are not accepted.")
@ -82,7 +82,6 @@ async def data_item_to_text_file(
return (
await loader.load_file(
data_item_path,
None,
preferred_loaders,
loaders_config=loaders_config, # TODO: right now loaders_config is only needed for web_url_loader, so keeping changes minimal
),