gmakstutis/cognee
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test: Update unit tests regrading exceptions

Browse source 
Updated unit tests to check for custom exceptions instead

Test COG-502
This commit is contained in:
Igor Ilic 2024-11-27 15:29:32 +01:00
parent 90287e0dac
commit 5d297c50f4
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
cognee/tests/unit/modules/graph/cognee_graph_elements_test.py
View file

@ -16,7 +16,7 @@ def test_node_initialization():
def test_node_invalid_dimension(): def test_node_invalid_dimension():
"""Test that initializing a Node with a non-positive dimension raises an error.""" """Test that initializing a Node with a non-positive dimension raises an error."""
with pytest.raises(ValueError, match="Dimension must be a positive integer"): with pytest.raises(InvalidValueError, match="Dimension must be a positive integer"):
Node("node1", dimension=0) Node("node1", dimension=0)
@ -69,7 +69,7 @@ def test_is_node_alive_in_dimension():
def test_node_alive_invalid_dimension(): def test_node_alive_invalid_dimension():
"""Test that checking alive status with an invalid dimension raises an error.""" """Test that checking alive status with an invalid dimension raises an error."""
node = Node("node1", dimension=1) node = Node("node1", dimension=1)
with pytest.raises(ValueError, match="Dimension 1 is out of range"): with pytest.raises(InvalidValueError, match="Dimension 1 is out of range"):
node.is_node_alive_in_dimension(1) node.is_node_alive_in_dimension(1)

8
cognee/tests/unit/modules/graph/cognee_graph_test.py
View file

@ -1,6 +1,6 @@
import pytest import pytest
from cognee.exceptions import InvalidValueError from cognee.exceptions import EntityNotFoundError, EntityAlreadyExistsError
from cognee.modules.graph.cognee_graph.CogneeGraph import CogneeGraph from cognee.modules.graph.cognee_graph.CogneeGraph import CogneeGraph
from cognee.modules.graph.cognee_graph.CogneeGraphElements import Edge, Node from cognee.modules.graph.cognee_graph.CogneeGraphElements import Edge, Node
@ -24,7 +24,7 @@ def test_add_duplicate_node(setup_graph):
graph = setup_graph graph = setup_graph
node = Node("node1") node = Node("node1")
graph.add_node(node) graph.add_node(node)
with pytest.raises(InvalidValueError, match="Node with id node1 already exists."): with pytest.raises(EntityAlreadyExistsError, match="Node with id node1 already exists."):
graph.add_node(node) graph.add_node(node)
@ -51,7 +51,7 @@ def test_add_duplicate_edge(setup_graph):
graph.add_node(node2) graph.add_node(node2)
edge = Edge(node1, node2) edge = Edge(node1, node2)
graph.add_edge(edge) graph.add_edge(edge)
with pytest.raises(InvalidValueError, match="Edge .* already exists in the graph."): with pytest.raises(EntityAlreadyExistsError, match="Edge .* already exists in the graph."):
graph.add_edge(edge) graph.add_edge(edge)
@ -84,5 +84,5 @@ def test_get_edges_success(setup_graph):
def test_get_edges_nonexistent_node(setup_graph): def test_get_edges_nonexistent_node(setup_graph):
"""Test retrieving edges for a nonexistent node raises an exception.""" """Test retrieving edges for a nonexistent node raises an exception."""
graph = setup_graph graph = setup_graph
with pytest.raises(InvalidValueError, match="Node with id nonexistent does not exist."): with pytest.raises(EntityNotFoundError, match="Node with id nonexistent does not exist."):
graph.get_edges("nonexistent") graph.get_edges("nonexistent")