diff --git a/level_3/rag_test_manager.py b/level_3/rag_test_manager.py index 204b5f918..8e50bb46e 100644 --- a/level_3/rag_test_manager.py +++ b/level_3/rag_test_manager.py @@ -298,6 +298,7 @@ async def start_test(data, test_set=None, user_id=None, params=None, job_id=None session = Session() + #do i need namespace in memory instance, fix it memory = Memory.create_memory(user_id, session, namespace="SEMANTICMEMORY") job_id = fetch_job_id(session, user_id = user_id,job_id =job_id) @@ -464,8 +465,8 @@ async def main(): return else: params = None - - await start_test(args.url, test_set, args.user_id, params, metadata) + #clean up params here + await start_test(args.url, test_set, args.user_id, params=None, metadata=params) if __name__ == "__main__": import asyncio diff --git a/level_3/vectorstore_manager.py b/level_3/vectorstore_manager.py index e001fc383..915b5445a 100644 --- a/level_3/vectorstore_manager.py +++ b/level_3/vectorstore_manager.py @@ -142,6 +142,7 @@ class Memory: self.short_term_memory = None self.namespace = namespace self.memory_instances = [] + #inspect and fix this self.memory_class = DynamicBaseMemory('Memory', user_id, str(self.memory_id), index_name, db_type, namespace) def load_environment_variables(self) -> None: load_dotenv() @@ -187,6 +188,8 @@ class Memory: @staticmethod def handle_new_user(user_id: str, session): """Handle new user creation in the DB and return the new memory ID.""" + + #handle these better in terms of retry and error handling memory_id = str(uuid.uuid4()) new_user = User(id=user_id) session.add(new_user)