From 38707ddabd4bf0e1c5d2ef04f0fa0de7e127bfa3 Mon Sep 17 00:00:00 2001 From: andikarachman Date: Sun, 4 Jan 2026 12:07:15 +0700 Subject: [PATCH] fix: improve error handling consistency - Use TranslationProviderError instead of ValueError in azure_provider.py batch translation - Replace bare except blocks with specific ValidationError in config_test.py --- cognee/tasks/translation/providers/azure_provider.py | 5 ++++- cognee/tests/tasks/translation/config_test.py | 7 +++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/cognee/tasks/translation/providers/azure_provider.py b/cognee/tasks/translation/providers/azure_provider.py index 8a3fc2b01..368585ffc 100644 --- a/cognee/tasks/translation/providers/azure_provider.py +++ b/cognee/tasks/translation/providers/azure_provider.py @@ -124,7 +124,10 @@ class AzureTranslationProvider(TranslationProvider): List of TranslationResult objects """ if not self.is_available(): - raise ValueError("Azure Translator API key not configured.") + raise TranslationProviderError( + provider=self.provider_name, + message="Azure Translator API key not configured. Set AZURE_TRANSLATOR_KEY environment variable.", + ) endpoint = f"{self._config.azure_translator_endpoint}/translate" diff --git a/cognee/tests/tasks/translation/config_test.py b/cognee/tests/tasks/translation/config_test.py index d5cf4971c..248bf70f3 100644 --- a/cognee/tests/tasks/translation/config_test.py +++ b/cognee/tests/tasks/translation/config_test.py @@ -3,6 +3,9 @@ Unit tests for translation configuration """ from typing import get_args + +from pydantic import ValidationError + from cognee.tasks.translation.config import ( get_translation_config, TranslationConfig, @@ -63,7 +66,7 @@ def test_confidence_threshold_validation(): assert 0.0 <= config_invalid_low.confidence_threshold <= 1.0, ( f"Invalid low value should be clamped, got {config_invalid_low.confidence_threshold}" ) - except Exception: + except ValidationError: pass # Expected validation error try: @@ -74,7 +77,7 @@ def test_confidence_threshold_validation(): assert 0.0 <= config_invalid_high.confidence_threshold <= 1.0, ( f"Invalid high value should be clamped, got {config_invalid_high.confidence_threshold}" ) - except Exception: + except ValidationError: pass # Expected validation error