From 2ea24dae4d0ff4ec0c29d4954cd6a6bb0fbbc60c Mon Sep 17 00:00:00 2001 From: Boris Arzentar Date: Tue, 14 Oct 2025 15:43:29 +0200 Subject: [PATCH] fix: move datasets import in delete cli command --- cognee/cli/commands/delete_command.py | 4 +--- cognee/tests/cli_tests/cli_unit_tests/test_cli_commands.py | 2 +- cognee/tests/cli_tests/cli_unit_tests/test_cli_edge_cases.py | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/cognee/cli/commands/delete_command.py b/cognee/cli/commands/delete_command.py index 80a48937b..1b6b653bf 100644 --- a/cognee/cli/commands/delete_command.py +++ b/cognee/cli/commands/delete_command.py @@ -5,6 +5,7 @@ from cognee.cli.reference import SupportsCliCommand from cognee.cli import DEFAULT_DOCS_URL import cognee.cli.echo as fmt from cognee.cli.exceptions import CliCommandException, CliCommandInnerException +from cognee.api.v1.datasets.datasets import datasets as cognee_datasets from cognee.modules.data.methods import get_datasets_by_name from cognee.modules.data.methods.get_deletion_counts import get_deletion_counts @@ -34,9 +35,6 @@ Be careful with deletion operations as they are irreversible. def execute(self, args: argparse.Namespace) -> None: try: - # Import cognee here to avoid circular imports - from cognee.api.v1.datasets.datasets import datasets as cognee_datasets - # Validate arguments if not any( [ diff --git a/cognee/tests/cli_tests/cli_unit_tests/test_cli_commands.py b/cognee/tests/cli_tests/cli_unit_tests/test_cli_commands.py index 46c1ea236..dc82fe342 100644 --- a/cognee/tests/cli_tests/cli_unit_tests/test_cli_commands.py +++ b/cognee/tests/cli_tests/cli_unit_tests/test_cli_commands.py @@ -286,7 +286,7 @@ class TestDeleteCommand: assert "force" in actions @patch("cognee.modules.data.methods.get_deletion_counts.get_user") - @patch("cognee.api.v1.datasets.datasets.datasets.delete_dataset") + @patch("cognee.cli.commands.delete_command.cognee_datasets.delete_dataset") @patch("cognee.cli.commands.delete_command.fmt.confirm") @patch("cognee.cli.commands.delete_command.asyncio.run", side_effect=_mock_run) def test_execute_delete_dataset_with_confirmation( diff --git a/cognee/tests/cli_tests/cli_unit_tests/test_cli_edge_cases.py b/cognee/tests/cli_tests/cli_unit_tests/test_cli_edge_cases.py index 4d5119568..dd23059a3 100644 --- a/cognee/tests/cli_tests/cli_unit_tests/test_cli_edge_cases.py +++ b/cognee/tests/cli_tests/cli_unit_tests/test_cli_edge_cases.py @@ -381,7 +381,7 @@ class TestDeleteCommandEdgeCases: """Test edge cases for DeleteCommand""" @patch("cognee.cli.commands.delete_command.asyncio.run", side_effect=_mock_run) - @patch("cognee.api.v1.datasets.datasets.datasets.delete_all") + @patch("cognee.cli.commands.delete_command.cognee_datasets.delete_all") @patch("cognee.cli.commands.delete_command.fmt.confirm") def test_delete_all_with_user_id(self, fmt_confirm_mock, delete_all_mock, async_run_mock): """Test delete command with both --all and --user-id"""