fix: address PR code review comments

Signed-off-by: shijianglong <stonyme@vip.qq.com>

cognee/infrastructure/databases/vector/embeddings/LiteLLMEmbeddingEngine.py

@@ -30,7 +30,6 @@ from cognee.infrastructure.llm.tokenizer.TikToken import (
 from cognee.shared.rate_limiting import embedding_rate_limiter_context_manager
 
 litellm.set_verbose = False
-litellm.drop_params = True
 logger = get_logger("LiteLLMEmbeddingEngine")
 
 
@@ -50,7 +49,7 @@ class LiteLLMEmbeddingEngine(EmbeddingEngine):
     api_version: str
     provider: str
     model: str
-    dimensions: int
+    dimensions: Optional[int]
     mock: bool
 
     MAX_RETRIES = 5
@@ -293,4 +292,4 @@ class LiteLLMEmbeddingEngine(EmbeddingEngine):
                 )
 
         logger.debug(f"Tokenizer loaded for model: {self.model}")
-        return tokenizer
+        return tokenizer

cognee/tests/unit/infrastructure/test_litellm_embedding_dimensions.py

@@ -1,6 +1,8 @@
-import pytest
 import os
 from unittest.mock import patch
+
+import pytest
+
 from cognee.infrastructure.databases.vector.embeddings.LiteLLMEmbeddingEngine import LiteLLMEmbeddingEngine
 
 @pytest.mark.asyncio
@@ -46,3 +48,9 @@ async def test_litellm_embedding_invalid_dimensions():
         
     with pytest.raises(ValueError, match="dimensions must be a positive integer"):
         LiteLLMEmbeddingEngine(dimensions=-100)
+    
+    with pytest.raises(ValueError, match="dimensions must be a positive integer"):
+        LiteLLMEmbeddingEngine(dimensions="1024") # type: ignore
+
+    with pytest.raises(ValueError, match="dimensions must be a positive integer"):
+        LiteLLMEmbeddingEngine(dimensions=1024.5) # type: ignore