From 6a693d319add7eaf7875599e2f965c0da5d43096 Mon Sep 17 00:00:00 2001 From: Daulet Amirkhanov Date: Thu, 16 Oct 2025 15:45:21 +0100 Subject: [PATCH 1/2] fix: preferred_loaders is always None in `data_item_to_text_file.load_file()` --- .../tasks/ingestion/data_item_to_text_file.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/cognee/tasks/ingestion/data_item_to_text_file.py b/cognee/tasks/ingestion/data_item_to_text_file.py index 9fcafca57..dc0d1d0a7 100644 --- a/cognee/tasks/ingestion/data_item_to_text_file.py +++ b/cognee/tasks/ingestion/data_item_to_text_file.py @@ -48,17 +48,17 @@ async def data_item_to_text_file( await pull_from_s3(data_item_path, temp_file) temp_file.flush() # Data needs to be saved to local storage loader = get_loader_engine() - return await loader.load_file(temp_file.name, preferred_loaders), loader.get_loader( - temp_file.name, preferred_loaders - ) + return await loader.load_file( + temp_file.name, None, preferred_loaders + ), loader.get_loader(temp_file.name, preferred_loaders) # data is local file path elif parsed_url.scheme == "file": if settings.accept_local_file_path: loader = get_loader_engine() - return await loader.load_file(data_item_path, preferred_loaders), loader.get_loader( - data_item_path, preferred_loaders - ) + return await loader.load_file( + data_item_path, None, preferred_loaders + ), loader.get_loader(data_item_path, preferred_loaders) else: raise IngestionError(message="Local files are not accepted.") @@ -69,9 +69,9 @@ async def data_item_to_text_file( # Handle both Unix absolute paths (/path) and Windows absolute paths (C:\path) if settings.accept_local_file_path: loader = get_loader_engine() - return await loader.load_file(data_item_path, preferred_loaders), loader.get_loader( - data_item_path, preferred_loaders - ) + return await loader.load_file( + data_item_path, None, preferred_loaders + ), loader.get_loader(data_item_path, preferred_loaders) else: raise IngestionError(message="Local files are not accepted.") From 50aa8aac115f8fcf4011e1001e86adf9afc89594 Mon Sep 17 00:00:00 2001 From: Daulet Amirkhanov Date: Fri, 17 Oct 2025 17:33:25 +0100 Subject: [PATCH 2/2] refactor: remove `filestream` arg from `LoaderEngine.load_file(...)` --- cognee/infrastructure/loaders/LoaderEngine.py | 1 - .../tasks/ingestion/data_item_to_text_file.py | 18 +++++++++--------- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/cognee/infrastructure/loaders/LoaderEngine.py b/cognee/infrastructure/loaders/LoaderEngine.py index 87a008660..6b62f7641 100644 --- a/cognee/infrastructure/loaders/LoaderEngine.py +++ b/cognee/infrastructure/loaders/LoaderEngine.py @@ -105,7 +105,6 @@ class LoaderEngine: async def load_file( self, file_path: str, - file_stream: Optional[Any], preferred_loaders: Optional[List[str]] = None, **kwargs, ): diff --git a/cognee/tasks/ingestion/data_item_to_text_file.py b/cognee/tasks/ingestion/data_item_to_text_file.py index dc0d1d0a7..9fcafca57 100644 --- a/cognee/tasks/ingestion/data_item_to_text_file.py +++ b/cognee/tasks/ingestion/data_item_to_text_file.py @@ -48,17 +48,17 @@ async def data_item_to_text_file( await pull_from_s3(data_item_path, temp_file) temp_file.flush() # Data needs to be saved to local storage loader = get_loader_engine() - return await loader.load_file( - temp_file.name, None, preferred_loaders - ), loader.get_loader(temp_file.name, preferred_loaders) + return await loader.load_file(temp_file.name, preferred_loaders), loader.get_loader( + temp_file.name, preferred_loaders + ) # data is local file path elif parsed_url.scheme == "file": if settings.accept_local_file_path: loader = get_loader_engine() - return await loader.load_file( - data_item_path, None, preferred_loaders - ), loader.get_loader(data_item_path, preferred_loaders) + return await loader.load_file(data_item_path, preferred_loaders), loader.get_loader( + data_item_path, preferred_loaders + ) else: raise IngestionError(message="Local files are not accepted.") @@ -69,9 +69,9 @@ async def data_item_to_text_file( # Handle both Unix absolute paths (/path) and Windows absolute paths (C:\path) if settings.accept_local_file_path: loader = get_loader_engine() - return await loader.load_file( - data_item_path, None, preferred_loaders - ), loader.get_loader(data_item_path, preferred_loaders) + return await loader.load_file(data_item_path, preferred_loaders), loader.get_loader( + data_item_path, preferred_loaders + ) else: raise IngestionError(message="Local files are not accepted.")