polish Memgraph implementation
This commit is contained in:
parent
7118b23ca2
commit
bd158d096b
1 changed files with 551 additions and 252 deletions
|
|
@ -89,183 +89,419 @@ class MemgraphStorage(BaseGraphStorage):
|
||||||
pass
|
pass
|
||||||
|
|
||||||
async def has_node(self, node_id: str) -> bool:
|
async def has_node(self, node_id: str) -> bool:
|
||||||
|
"""
|
||||||
|
Check if a node exists in the graph.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
node_id: The ID of the node to check.
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
bool: True if the node exists, False otherwise.
|
||||||
|
|
||||||
|
Raises:
|
||||||
|
Exception: If there is an error checking the node existence.
|
||||||
|
"""
|
||||||
async with self._driver.session(
|
async with self._driver.session(
|
||||||
database=self._DATABASE, default_access_mode="READ"
|
database=self._DATABASE, default_access_mode="READ"
|
||||||
) as session:
|
) as session:
|
||||||
query = "MATCH (n:base {entity_id: $entity_id}) RETURN count(n) > 0 AS node_exists"
|
try:
|
||||||
result = await session.run(query, entity_id=node_id)
|
query = "MATCH (n:base {entity_id: $entity_id}) RETURN count(n) > 0 AS node_exists"
|
||||||
single_result = await result.single()
|
result = await session.run(query, entity_id=node_id)
|
||||||
await result.consume()
|
single_result = await result.single()
|
||||||
return single_result["node_exists"]
|
await result.consume() # Ensure result is fully consumed
|
||||||
|
return single_result["node_exists"]
|
||||||
|
except Exception as e:
|
||||||
|
logger.error(f"Error checking node existence for {node_id}: {str(e)}")
|
||||||
|
await result.consume() # Ensure the result is consumed even on error
|
||||||
|
raise
|
||||||
|
|
||||||
async def has_edge(self, source_node_id: str, target_node_id: str) -> bool:
|
async def has_edge(self, source_node_id: str, target_node_id: str) -> bool:
|
||||||
|
"""
|
||||||
|
Check if an edge exists between two nodes in the graph.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
source_node_id: The ID of the source node.
|
||||||
|
target_node_id: The ID of the target node.
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
bool: True if the edge exists, False otherwise.
|
||||||
|
|
||||||
|
Raises:
|
||||||
|
Exception: If there is an error checking the edge existence.
|
||||||
|
"""
|
||||||
async with self._driver.session(
|
async with self._driver.session(
|
||||||
database=self._DATABASE, default_access_mode="READ"
|
database=self._DATABASE, default_access_mode="READ"
|
||||||
) as session:
|
) as session:
|
||||||
query = (
|
try:
|
||||||
"MATCH (a:base {entity_id: $source_entity_id})-[r]-(b:base {entity_id: $target_entity_id}) "
|
query = (
|
||||||
"RETURN COUNT(r) > 0 AS edgeExists"
|
"MATCH (a:base {entity_id: $source_entity_id})-[r]-(b:base {entity_id: $target_entity_id}) "
|
||||||
)
|
"RETURN COUNT(r) > 0 AS edgeExists"
|
||||||
result = await session.run(
|
)
|
||||||
query,
|
result = await session.run(
|
||||||
source_entity_id=source_node_id,
|
query,
|
||||||
target_entity_id=target_node_id,
|
source_entity_id=source_node_id,
|
||||||
)
|
target_entity_id=target_node_id,
|
||||||
single_result = await result.single()
|
)
|
||||||
await result.consume()
|
single_result = await result.single()
|
||||||
return single_result["edgeExists"]
|
await result.consume() # Ensure result is fully consumed
|
||||||
|
return single_result["edgeExists"]
|
||||||
|
except Exception as e:
|
||||||
|
logger.error(
|
||||||
|
f"Error checking edge existence between {source_node_id} and {target_node_id}: {str(e)}"
|
||||||
|
)
|
||||||
|
await result.consume() # Ensure the result is consumed even on error
|
||||||
|
raise
|
||||||
|
|
||||||
async def get_node(self, node_id: str) -> dict[str, str] | None:
|
async def get_node(self, node_id: str) -> dict[str, str] | None:
|
||||||
|
"""Get node by its label identifier, return only node properties
|
||||||
|
|
||||||
|
Args:
|
||||||
|
node_id: The node label to look up
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
dict: Node properties if found
|
||||||
|
None: If node not found
|
||||||
|
|
||||||
|
Raises:
|
||||||
|
Exception: If there is an error executing the query
|
||||||
|
"""
|
||||||
async with self._driver.session(
|
async with self._driver.session(
|
||||||
database=self._DATABASE, default_access_mode="READ"
|
database=self._DATABASE, default_access_mode="READ"
|
||||||
) as session:
|
) as session:
|
||||||
query = "MATCH (n:base {entity_id: $entity_id}) RETURN n"
|
try:
|
||||||
result = await session.run(query, entity_id=node_id)
|
query = "MATCH (n:base {entity_id: $entity_id}) RETURN n"
|
||||||
records = await result.fetch(2)
|
result = await session.run(query, entity_id=node_id)
|
||||||
await result.consume()
|
try:
|
||||||
if records:
|
records = await result.fetch(
|
||||||
node = records[0]["n"]
|
2
|
||||||
node_dict = dict(node)
|
) # Get 2 records for duplication check
|
||||||
if "labels" in node_dict:
|
|
||||||
node_dict["labels"] = [
|
if len(records) > 1:
|
||||||
label for label in node_dict["labels"] if label != "base"
|
logger.warning(
|
||||||
]
|
f"Multiple nodes found with label '{node_id}'. Using first node."
|
||||||
return node_dict
|
)
|
||||||
return None
|
if records:
|
||||||
|
node = records[0]["n"]
|
||||||
|
node_dict = dict(node)
|
||||||
|
# Remove base label from labels list if it exists
|
||||||
|
if "labels" in node_dict:
|
||||||
|
node_dict["labels"] = [
|
||||||
|
label
|
||||||
|
for label in node_dict["labels"]
|
||||||
|
if label != "base"
|
||||||
|
]
|
||||||
|
return node_dict
|
||||||
|
return None
|
||||||
|
finally:
|
||||||
|
await result.consume() # Ensure result is fully consumed
|
||||||
|
except Exception as e:
|
||||||
|
logger.error(f"Error getting node for {node_id}: {str(e)}")
|
||||||
|
raise
|
||||||
|
|
||||||
|
async def node_degree(self, node_id: str) -> int:
|
||||||
|
"""Get the degree (number of relationships) of a node with the given label.
|
||||||
|
If multiple nodes have the same label, returns the degree of the first node.
|
||||||
|
If no node is found, returns 0.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
node_id: The label of the node
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
int: The number of relationships the node has, or 0 if no node found
|
||||||
|
|
||||||
|
Raises:
|
||||||
|
Exception: If there is an error executing the query
|
||||||
|
"""
|
||||||
|
async with self._driver.session(
|
||||||
|
database=self._DATABASE, default_access_mode="READ"
|
||||||
|
) as session:
|
||||||
|
try:
|
||||||
|
query = """
|
||||||
|
MATCH (n:base {entity_id: $entity_id})
|
||||||
|
OPTIONAL MATCH (n)-[r]-()
|
||||||
|
RETURN COUNT(r) AS degree
|
||||||
|
"""
|
||||||
|
result = await session.run(query, entity_id=node_id)
|
||||||
|
try:
|
||||||
|
record = await result.single()
|
||||||
|
|
||||||
|
if not record:
|
||||||
|
logger.warning(f"No node found with label '{node_id}'")
|
||||||
|
return 0
|
||||||
|
|
||||||
|
degree = record["degree"]
|
||||||
|
return degree
|
||||||
|
finally:
|
||||||
|
await result.consume() # Ensure result is fully consumed
|
||||||
|
except Exception as e:
|
||||||
|
logger.error(f"Error getting node degree for {node_id}: {str(e)}")
|
||||||
|
raise
|
||||||
|
|
||||||
async def get_all_labels(self) -> list[str]:
|
async def get_all_labels(self) -> list[str]:
|
||||||
|
"""
|
||||||
|
Get all existing node labels in the database
|
||||||
|
Returns:
|
||||||
|
["Person", "Company", ...] # Alphabetically sorted label list
|
||||||
|
|
||||||
|
Raises:
|
||||||
|
Exception: If there is an error executing the query
|
||||||
|
"""
|
||||||
async with self._driver.session(
|
async with self._driver.session(
|
||||||
database=self._DATABASE, default_access_mode="READ"
|
database=self._DATABASE, default_access_mode="READ"
|
||||||
) as session:
|
) as session:
|
||||||
query = """
|
try:
|
||||||
MATCH (n:base)
|
query = """
|
||||||
WHERE n.entity_id IS NOT NULL
|
MATCH (n:base)
|
||||||
RETURN DISTINCT n.entity_id AS label
|
WHERE n.entity_id IS NOT NULL
|
||||||
ORDER BY label
|
RETURN DISTINCT n.entity_id AS label
|
||||||
"""
|
ORDER BY label
|
||||||
result = await session.run(query)
|
"""
|
||||||
labels = []
|
result = await session.run(query)
|
||||||
async for record in result:
|
labels = []
|
||||||
labels.append(record["label"])
|
async for record in result:
|
||||||
await result.consume()
|
labels.append(record["label"])
|
||||||
return labels
|
await result.consume()
|
||||||
|
return labels
|
||||||
|
except Exception as e:
|
||||||
|
logger.error(f"Error getting all labels: {str(e)}")
|
||||||
|
await result.consume() # Ensure the result is consumed even on error
|
||||||
|
raise
|
||||||
|
|
||||||
async def get_node_edges(self, source_node_id: str) -> list[tuple[str, str]] | None:
|
async def get_node_edges(self, source_node_id: str) -> list[tuple[str, str]] | None:
|
||||||
async with self._driver.session(
|
"""Retrieves all edges (relationships) for a particular node identified by its label.
|
||||||
database=self._DATABASE, default_access_mode="READ"
|
|
||||||
) as session:
|
Args:
|
||||||
query = """
|
source_node_id: Label of the node to get edges for
|
||||||
MATCH (n:base {entity_id: $entity_id})
|
|
||||||
OPTIONAL MATCH (n)-[r]-(connected:base)
|
Returns:
|
||||||
WHERE connected.entity_id IS NOT NULL
|
list[tuple[str, str]]: List of (source_label, target_label) tuples representing edges
|
||||||
RETURN n, r, connected
|
None: If no edges found
|
||||||
"""
|
|
||||||
results = await session.run(query, entity_id=source_node_id)
|
Raises:
|
||||||
edges = []
|
Exception: If there is an error executing the query
|
||||||
async for record in results:
|
"""
|
||||||
source_node = record["n"]
|
try:
|
||||||
connected_node = record["connected"]
|
async with self._driver.session(
|
||||||
if not source_node or not connected_node:
|
database=self._DATABASE, default_access_mode="READ"
|
||||||
continue
|
) as session:
|
||||||
source_label = source_node.get("entity_id")
|
try:
|
||||||
target_label = connected_node.get("entity_id")
|
query = """MATCH (n:base {entity_id: $entity_id})
|
||||||
if source_label and target_label:
|
OPTIONAL MATCH (n)-[r]-(connected:base)
|
||||||
edges.append((source_label, target_label))
|
WHERE connected.entity_id IS NOT NULL
|
||||||
await results.consume()
|
RETURN n, r, connected"""
|
||||||
return edges
|
results = await session.run(query, entity_id=source_node_id)
|
||||||
|
|
||||||
|
edges = []
|
||||||
|
async for record in results:
|
||||||
|
source_node = record["n"]
|
||||||
|
connected_node = record["connected"]
|
||||||
|
|
||||||
|
# Skip if either node is None
|
||||||
|
if not source_node or not connected_node:
|
||||||
|
continue
|
||||||
|
|
||||||
|
source_label = (
|
||||||
|
source_node.get("entity_id")
|
||||||
|
if source_node.get("entity_id")
|
||||||
|
else None
|
||||||
|
)
|
||||||
|
target_label = (
|
||||||
|
connected_node.get("entity_id")
|
||||||
|
if connected_node.get("entity_id")
|
||||||
|
else None
|
||||||
|
)
|
||||||
|
|
||||||
|
if source_label and target_label:
|
||||||
|
edges.append((source_label, target_label))
|
||||||
|
|
||||||
|
await results.consume() # Ensure results are consumed
|
||||||
|
return edges
|
||||||
|
except Exception as e:
|
||||||
|
logger.error(
|
||||||
|
f"Error getting edges for node {source_node_id}: {str(e)}"
|
||||||
|
)
|
||||||
|
await results.consume() # Ensure results are consumed even on error
|
||||||
|
raise
|
||||||
|
except Exception as e:
|
||||||
|
logger.error(f"Error in get_node_edges for {source_node_id}: {str(e)}")
|
||||||
|
raise
|
||||||
|
|
||||||
async def get_edge(
|
async def get_edge(
|
||||||
self, source_node_id: str, target_node_id: str
|
self, source_node_id: str, target_node_id: str
|
||||||
) -> dict[str, str] | None:
|
) -> dict[str, str] | None:
|
||||||
|
"""Get edge properties between two nodes.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
source_node_id: Label of the source node
|
||||||
|
target_node_id: Label of the target node
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
dict: Edge properties if found, default properties if not found or on error
|
||||||
|
|
||||||
|
Raises:
|
||||||
|
Exception: If there is an error executing the query
|
||||||
|
"""
|
||||||
async with self._driver.session(
|
async with self._driver.session(
|
||||||
database=self._DATABASE, default_access_mode="READ"
|
database=self._DATABASE, default_access_mode="READ"
|
||||||
) as session:
|
) as session:
|
||||||
query = """
|
try:
|
||||||
MATCH (start:base {entity_id: $source_entity_id})-[r]-(end:base {entity_id: $target_entity_id})
|
query = """
|
||||||
RETURN properties(r) as edge_properties
|
MATCH (start:base {entity_id: $source_entity_id})-[r]-(end:base {entity_id: $target_entity_id})
|
||||||
"""
|
RETURN properties(r) as edge_properties
|
||||||
result = await session.run(
|
"""
|
||||||
query,
|
result = await session.run(
|
||||||
source_entity_id=source_node_id,
|
query,
|
||||||
target_entity_id=target_node_id,
|
source_entity_id=source_node_id,
|
||||||
)
|
target_entity_id=target_node_id,
|
||||||
records = await result.fetch(2)
|
)
|
||||||
await result.consume()
|
records = await result.fetch(2)
|
||||||
if records:
|
await result.consume()
|
||||||
edge_result = dict(records[0]["edge_properties"])
|
if records:
|
||||||
for key, default_value in {
|
edge_result = dict(records[0]["edge_properties"])
|
||||||
"weight": 0.0,
|
for key, default_value in {
|
||||||
"source_id": None,
|
"weight": 0.0,
|
||||||
"description": None,
|
"source_id": None,
|
||||||
"keywords": None,
|
"description": None,
|
||||||
}.items():
|
"keywords": None,
|
||||||
if key not in edge_result:
|
}.items():
|
||||||
edge_result[key] = default_value
|
if key not in edge_result:
|
||||||
return edge_result
|
edge_result[key] = default_value
|
||||||
return None
|
logger.warning(
|
||||||
|
f"Edge between {source_node_id} and {target_node_id} is missing property: {key}. Using default value: {default_value}"
|
||||||
|
)
|
||||||
|
return edge_result
|
||||||
|
return None
|
||||||
|
except Exception as e:
|
||||||
|
logger.error(
|
||||||
|
f"Error getting edge between {source_node_id} and {target_node_id}: {str(e)}"
|
||||||
|
)
|
||||||
|
await result.consume() # Ensure the result is consumed even on error
|
||||||
|
raise
|
||||||
|
|
||||||
async def upsert_node(self, node_id: str, node_data: dict[str, str]) -> None:
|
async def upsert_node(self, node_id: str, node_data: dict[str, str]) -> None:
|
||||||
|
"""
|
||||||
|
Upsert a node in the Neo4j database.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
node_id: The unique identifier for the node (used as label)
|
||||||
|
node_data: Dictionary of node properties
|
||||||
|
"""
|
||||||
properties = node_data
|
properties = node_data
|
||||||
entity_type = properties.get("entity_type", "base")
|
entity_type = properties["entity_type"]
|
||||||
if "entity_id" not in properties:
|
if "entity_id" not in properties:
|
||||||
raise ValueError(
|
raise ValueError("Neo4j: node properties must contain an 'entity_id' field")
|
||||||
"Memgraph: node properties must contain an 'entity_id' field"
|
|
||||||
)
|
|
||||||
async with self._driver.session(database=self._DATABASE) as session:
|
|
||||||
|
|
||||||
async def execute_upsert(tx: AsyncManagedTransaction):
|
try:
|
||||||
query = f"""
|
async with self._driver.session(database=self._DATABASE) as session:
|
||||||
MERGE (n:base {{entity_id: $entity_id}})
|
|
||||||
|
async def execute_upsert(tx: AsyncManagedTransaction):
|
||||||
|
query = (
|
||||||
|
"""
|
||||||
|
MERGE (n:base {entity_id: $entity_id})
|
||||||
SET n += $properties
|
SET n += $properties
|
||||||
SET n:`{entity_type}`
|
SET n:`%s`
|
||||||
"""
|
"""
|
||||||
result = await tx.run(query, entity_id=node_id, properties=properties)
|
% entity_type
|
||||||
await result.consume()
|
)
|
||||||
|
result = await tx.run(
|
||||||
|
query, entity_id=node_id, properties=properties
|
||||||
|
)
|
||||||
|
await result.consume() # Ensure result is fully consumed
|
||||||
|
|
||||||
await session.execute_write(execute_upsert)
|
await session.execute_write(execute_upsert)
|
||||||
|
except Exception as e:
|
||||||
|
logger.error(f"Error during upsert: {str(e)}")
|
||||||
|
raise
|
||||||
|
|
||||||
async def upsert_edge(
|
async def upsert_edge(
|
||||||
self, source_node_id: str, target_node_id: str, edge_data: dict[str, str]
|
self, source_node_id: str, target_node_id: str, edge_data: dict[str, str]
|
||||||
) -> None:
|
) -> None:
|
||||||
edge_properties = edge_data
|
"""
|
||||||
async with self._driver.session(database=self._DATABASE) as session:
|
Upsert an edge and its properties between two nodes identified by their labels.
|
||||||
|
Ensures both source and target nodes exist and are unique before creating the edge.
|
||||||
|
Uses entity_id property to uniquely identify nodes.
|
||||||
|
|
||||||
async def execute_upsert(tx: AsyncManagedTransaction):
|
Args:
|
||||||
query = """
|
source_node_id (str): Label of the source node (used as identifier)
|
||||||
MATCH (source:base {entity_id: $source_entity_id})
|
target_node_id (str): Label of the target node (used as identifier)
|
||||||
WITH source
|
edge_data (dict): Dictionary of properties to set on the edge
|
||||||
MATCH (target:base {entity_id: $target_entity_id})
|
|
||||||
MERGE (source)-[r:DIRECTED]-(target)
|
|
||||||
SET r += $properties
|
|
||||||
RETURN r, source, target
|
|
||||||
"""
|
|
||||||
result = await tx.run(
|
|
||||||
query,
|
|
||||||
source_entity_id=source_node_id,
|
|
||||||
target_entity_id=target_node_id,
|
|
||||||
properties=edge_properties,
|
|
||||||
)
|
|
||||||
await result.consume()
|
|
||||||
|
|
||||||
await session.execute_write(execute_upsert)
|
Raises:
|
||||||
|
Exception: If there is an error executing the query
|
||||||
|
"""
|
||||||
|
try:
|
||||||
|
edge_properties = edge_data
|
||||||
|
async with self._driver.session(database=self._DATABASE) as session:
|
||||||
|
|
||||||
|
async def execute_upsert(tx: AsyncManagedTransaction):
|
||||||
|
query = """
|
||||||
|
MATCH (source:base {entity_id: $source_entity_id})
|
||||||
|
WITH source
|
||||||
|
MATCH (target:base {entity_id: $target_entity_id})
|
||||||
|
MERGE (source)-[r:DIRECTED]-(target)
|
||||||
|
SET r += $properties
|
||||||
|
RETURN r, source, target
|
||||||
|
"""
|
||||||
|
result = await tx.run(
|
||||||
|
query,
|
||||||
|
source_entity_id=source_node_id,
|
||||||
|
target_entity_id=target_node_id,
|
||||||
|
properties=edge_properties,
|
||||||
|
)
|
||||||
|
try:
|
||||||
|
await result.fetch(2)
|
||||||
|
finally:
|
||||||
|
await result.consume() # Ensure result is consumed
|
||||||
|
|
||||||
|
await session.execute_write(execute_upsert)
|
||||||
|
except Exception as e:
|
||||||
|
logger.error(f"Error during edge upsert: {str(e)}")
|
||||||
|
raise
|
||||||
|
|
||||||
async def delete_node(self, node_id: str) -> None:
|
async def delete_node(self, node_id: str) -> None:
|
||||||
|
"""Delete a node with the specified label
|
||||||
|
|
||||||
|
Args:
|
||||||
|
node_id: The label of the node to delete
|
||||||
|
|
||||||
|
Raises:
|
||||||
|
Exception: If there is an error executing the query
|
||||||
|
"""
|
||||||
|
|
||||||
async def _do_delete(tx: AsyncManagedTransaction):
|
async def _do_delete(tx: AsyncManagedTransaction):
|
||||||
query = """
|
query = """
|
||||||
MATCH (n:base {entity_id: $entity_id})
|
MATCH (n:base {entity_id: $entity_id})
|
||||||
DETACH DELETE n
|
DETACH DELETE n
|
||||||
"""
|
"""
|
||||||
result = await tx.run(query, entity_id=node_id)
|
result = await tx.run(query, entity_id=node_id)
|
||||||
|
logger.debug(f"Deleted node with label {node_id}")
|
||||||
await result.consume()
|
await result.consume()
|
||||||
|
|
||||||
async with self._driver.session(database=self._DATABASE) as session:
|
try:
|
||||||
await session.execute_write(_do_delete)
|
async with self._driver.session(database=self._DATABASE) as session:
|
||||||
|
await session.execute_write(_do_delete)
|
||||||
|
except Exception as e:
|
||||||
|
logger.error(f"Error during node deletion: {str(e)}")
|
||||||
|
raise
|
||||||
|
|
||||||
async def remove_nodes(self, nodes: list[str]):
|
async def remove_nodes(self, nodes: list[str]):
|
||||||
|
"""Delete multiple nodes
|
||||||
|
|
||||||
|
Args:
|
||||||
|
nodes: List of node labels to be deleted
|
||||||
|
"""
|
||||||
for node in nodes:
|
for node in nodes:
|
||||||
await self.delete_node(node)
|
await self.delete_node(node)
|
||||||
|
|
||||||
async def remove_edges(self, edges: list[tuple[str, str]]):
|
async def remove_edges(self, edges: list[tuple[str, str]]):
|
||||||
|
"""Delete multiple edges
|
||||||
|
|
||||||
|
Args:
|
||||||
|
edges: List of edges to be deleted, each edge is a (source, target) tuple
|
||||||
|
|
||||||
|
Raises:
|
||||||
|
Exception: If there is an error executing the query
|
||||||
|
"""
|
||||||
for source, target in edges:
|
for source, target in edges:
|
||||||
|
|
||||||
async def _do_delete_edge(tx: AsyncManagedTransaction):
|
async def _do_delete_edge(tx: AsyncManagedTransaction):
|
||||||
|
|
@ -276,15 +512,32 @@ class MemgraphStorage(BaseGraphStorage):
|
||||||
result = await tx.run(
|
result = await tx.run(
|
||||||
query, source_entity_id=source, target_entity_id=target
|
query, source_entity_id=source, target_entity_id=target
|
||||||
)
|
)
|
||||||
await result.consume()
|
logger.debug(f"Deleted edge from '{source}' to '{target}'")
|
||||||
|
await result.consume() # Ensure result is fully consumed
|
||||||
|
|
||||||
async with self._driver.session(database=self._DATABASE) as session:
|
try:
|
||||||
await session.execute_write(_do_delete_edge)
|
async with self._driver.session(database=self._DATABASE) as session:
|
||||||
|
await session.execute_write(_do_delete_edge)
|
||||||
|
except Exception as e:
|
||||||
|
logger.error(f"Error during edge deletion: {str(e)}")
|
||||||
|
raise
|
||||||
|
|
||||||
async def drop(self) -> dict[str, str]:
|
async def drop(self) -> dict[str, str]:
|
||||||
|
"""Drop all data from storage and clean up resources
|
||||||
|
|
||||||
|
This method will delete all nodes and relationships in the Neo4j database.
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
dict[str, str]: Operation status and message
|
||||||
|
- On success: {"status": "success", "message": "data dropped"}
|
||||||
|
- On failure: {"status": "error", "message": "<error details>"}
|
||||||
|
|
||||||
|
Raises:
|
||||||
|
Exception: If there is an error executing the query
|
||||||
|
"""
|
||||||
try:
|
try:
|
||||||
async with self._driver.session(database=self._DATABASE) as session:
|
async with self._driver.session(database=self._DATABASE) as session:
|
||||||
query = "MATCH (n) DETACH DELETE n"
|
query = "DROP GRAPH"
|
||||||
result = await session.run(query)
|
result = await session.run(query)
|
||||||
await result.consume()
|
await result.consume()
|
||||||
logger.info(
|
logger.info(
|
||||||
|
|
@ -295,30 +548,36 @@ class MemgraphStorage(BaseGraphStorage):
|
||||||
logger.error(f"Error dropping Memgraph database {self._DATABASE}: {e}")
|
logger.error(f"Error dropping Memgraph database {self._DATABASE}: {e}")
|
||||||
return {"status": "error", "message": str(e)}
|
return {"status": "error", "message": str(e)}
|
||||||
|
|
||||||
async def node_degree(self, node_id: str) -> int:
|
|
||||||
async with self._driver.session(
|
|
||||||
database=self._DATABASE, default_access_mode="READ"
|
|
||||||
) as session:
|
|
||||||
query = """
|
|
||||||
MATCH (n:base {entity_id: $entity_id})
|
|
||||||
OPTIONAL MATCH (n)-[r]-()
|
|
||||||
RETURN COUNT(r) AS degree
|
|
||||||
"""
|
|
||||||
result = await session.run(query, entity_id=node_id)
|
|
||||||
record = await result.single()
|
|
||||||
await result.consume()
|
|
||||||
if not record:
|
|
||||||
return 0
|
|
||||||
return record["degree"]
|
|
||||||
|
|
||||||
async def edge_degree(self, src_id: str, tgt_id: str) -> int:
|
async def edge_degree(self, src_id: str, tgt_id: str) -> int:
|
||||||
|
"""Get the total degree (sum of relationships) of two nodes.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
src_id: Label of the source node
|
||||||
|
tgt_id: Label of the target node
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
int: Sum of the degrees of both nodes
|
||||||
|
"""
|
||||||
src_degree = await self.node_degree(src_id)
|
src_degree = await self.node_degree(src_id)
|
||||||
trg_degree = await self.node_degree(tgt_id)
|
trg_degree = await self.node_degree(tgt_id)
|
||||||
|
|
||||||
|
# Convert None to 0 for addition
|
||||||
src_degree = 0 if src_degree is None else src_degree
|
src_degree = 0 if src_degree is None else src_degree
|
||||||
trg_degree = 0 if trg_degree is None else trg_degree
|
trg_degree = 0 if trg_degree is None else trg_degree
|
||||||
return int(src_degree) + int(trg_degree)
|
|
||||||
|
degrees = int(src_degree) + int(trg_degree)
|
||||||
|
return degrees
|
||||||
|
|
||||||
async def get_nodes_by_chunk_ids(self, chunk_ids: list[str]) -> list[dict]:
|
async def get_nodes_by_chunk_ids(self, chunk_ids: list[str]) -> list[dict]:
|
||||||
|
"""Get all nodes that are associated with the given chunk_ids.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
chunk_ids: List of chunk IDs to find associated nodes for
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
list[dict]: A list of nodes, where each node is a dictionary of its properties.
|
||||||
|
An empty list if no matching nodes are found.
|
||||||
|
"""
|
||||||
async with self._driver.session(
|
async with self._driver.session(
|
||||||
database=self._DATABASE, default_access_mode="READ"
|
database=self._DATABASE, default_access_mode="READ"
|
||||||
) as session:
|
) as session:
|
||||||
|
|
@ -335,10 +594,19 @@ class MemgraphStorage(BaseGraphStorage):
|
||||||
node_dict = dict(node)
|
node_dict = dict(node)
|
||||||
node_dict["id"] = node_dict.get("entity_id")
|
node_dict["id"] = node_dict.get("entity_id")
|
||||||
nodes.append(node_dict)
|
nodes.append(node_dict)
|
||||||
await result.consume()
|
await result.consume()
|
||||||
return nodes
|
return nodes
|
||||||
|
|
||||||
async def get_edges_by_chunk_ids(self, chunk_ids: list[str]) -> list[dict]:
|
async def get_edges_by_chunk_ids(self, chunk_ids: list[str]) -> list[dict]:
|
||||||
|
"""Get all edges that are associated with the given chunk_ids.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
chunk_ids: List of chunk IDs to find associated edges for
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
list[dict]: A list of edges, where each edge is a dictionary of its properties.
|
||||||
|
An empty list if no matching edges are found.
|
||||||
|
"""
|
||||||
async with self._driver.session(
|
async with self._driver.session(
|
||||||
database=self._DATABASE, default_access_mode="READ"
|
database=self._DATABASE, default_access_mode="READ"
|
||||||
) as session:
|
) as session:
|
||||||
|
|
@ -364,118 +632,149 @@ class MemgraphStorage(BaseGraphStorage):
|
||||||
max_depth: int = 3,
|
max_depth: int = 3,
|
||||||
max_nodes: int = MAX_GRAPH_NODES,
|
max_nodes: int = MAX_GRAPH_NODES,
|
||||||
) -> KnowledgeGraph:
|
) -> KnowledgeGraph:
|
||||||
|
"""
|
||||||
|
Retrieve a connected subgraph of nodes where the label includes the specified `node_label`.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
node_label: Label of the starting node, * means all nodes
|
||||||
|
max_depth: Maximum depth of the subgraph, Defaults to 3
|
||||||
|
max_nodes: Maxiumu nodes to return by BFS, Defaults to 1000
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
KnowledgeGraph object containing nodes and edges, with an is_truncated flag
|
||||||
|
indicating whether the graph was truncated due to max_nodes limit
|
||||||
|
|
||||||
|
Raises:
|
||||||
|
Exception: If there is an error executing the query
|
||||||
|
"""
|
||||||
result = KnowledgeGraph()
|
result = KnowledgeGraph()
|
||||||
seen_nodes = set()
|
seen_nodes = set()
|
||||||
seen_edges = set()
|
seen_edges = set()
|
||||||
async with self._driver.session(
|
try:
|
||||||
database=self._DATABASE, default_access_mode="READ"
|
async with self._driver.session(
|
||||||
) as session:
|
database=self._DATABASE, default_access_mode="READ"
|
||||||
if node_label == "*":
|
) as session:
|
||||||
count_query = "MATCH (n) RETURN count(n) as total"
|
if node_label == "*":
|
||||||
count_result = await session.run(count_query)
|
count_query = "MATCH (n) RETURN count(n) as total"
|
||||||
count_record = await count_result.single()
|
count_result = None
|
||||||
await count_result.consume()
|
try:
|
||||||
if count_record and count_record["total"] > max_nodes:
|
count_result = await session.run(count_query)
|
||||||
result.is_truncated = True
|
count_record = await count_result.single()
|
||||||
logger.info(
|
if count_record and count_record["total"] > max_nodes:
|
||||||
f"Graph truncated: {count_record['total']} nodes found, limited to {max_nodes}"
|
result.is_truncated = True
|
||||||
)
|
logger.info(
|
||||||
main_query = """
|
f"Graph truncated: {count_record['total']} nodes found, limited to {max_nodes}"
|
||||||
MATCH (n)
|
)
|
||||||
OPTIONAL MATCH (n)-[r]-()
|
finally:
|
||||||
WITH n, COALESCE(count(r), 0) AS degree
|
if count_result:
|
||||||
ORDER BY degree DESC
|
await count_result.consume()
|
||||||
LIMIT $max_nodes
|
|
||||||
WITH collect({node: n}) AS filtered_nodes
|
|
||||||
UNWIND filtered_nodes AS node_info
|
|
||||||
WITH collect(node_info.node) AS kept_nodes, filtered_nodes
|
|
||||||
OPTIONAL MATCH (a)-[r]-(b)
|
|
||||||
WHERE a IN kept_nodes AND b IN kept_nodes
|
|
||||||
RETURN filtered_nodes AS node_info,
|
|
||||||
collect(DISTINCT r) AS relationships
|
|
||||||
"""
|
|
||||||
result_set = await session.run(main_query, {"max_nodes": max_nodes})
|
|
||||||
record = await result_set.single()
|
|
||||||
await result_set.consume()
|
|
||||||
else:
|
|
||||||
# BFS fallback for Memgraph (no APOC)
|
|
||||||
from collections import deque
|
|
||||||
|
|
||||||
# Get the starting node
|
# Run the main query to get nodes with highest degree
|
||||||
start_query = "MATCH (n:base {entity_id: $entity_id}) RETURN n"
|
main_query = """
|
||||||
node_result = await session.run(start_query, entity_id=node_label)
|
MATCH (n)
|
||||||
node_record = await node_result.single()
|
OPTIONAL MATCH (n)-[r]-()
|
||||||
await node_result.consume()
|
WITH n, COALESCE(count(r), 0) AS degree
|
||||||
if not node_record:
|
ORDER BY degree DESC
|
||||||
return result
|
LIMIT $max_nodes
|
||||||
start_node = node_record["n"]
|
WITH collect({node: n}) AS filtered_nodes
|
||||||
queue = deque([(start_node, 0)])
|
UNWIND filtered_nodes AS node_info
|
||||||
visited = set()
|
WITH collect(node_info.node) AS kept_nodes, filtered_nodes
|
||||||
bfs_nodes = []
|
OPTIONAL MATCH (a)-[r]-(b)
|
||||||
while queue and len(bfs_nodes) < max_nodes:
|
WHERE a IN kept_nodes AND b IN kept_nodes
|
||||||
current_node, depth = queue.popleft()
|
RETURN filtered_nodes AS node_info,
|
||||||
node_id = current_node.get("entity_id")
|
collect(DISTINCT r) AS relationships
|
||||||
if node_id in visited:
|
|
||||||
continue
|
|
||||||
visited.add(node_id)
|
|
||||||
bfs_nodes.append(current_node)
|
|
||||||
if depth < max_depth:
|
|
||||||
# Get neighbors
|
|
||||||
neighbor_query = """
|
|
||||||
MATCH (n:base {entity_id: $entity_id})-[]-(m:base)
|
|
||||||
RETURN m
|
|
||||||
"""
|
|
||||||
neighbors_result = await session.run(
|
|
||||||
neighbor_query, entity_id=node_id
|
|
||||||
)
|
|
||||||
neighbors = [
|
|
||||||
rec["m"] for rec in await neighbors_result.to_list()
|
|
||||||
]
|
|
||||||
await neighbors_result.consume()
|
|
||||||
for neighbor in neighbors:
|
|
||||||
neighbor_id = neighbor.get("entity_id")
|
|
||||||
if neighbor_id not in visited:
|
|
||||||
queue.append((neighbor, depth + 1))
|
|
||||||
# Build subgraph
|
|
||||||
subgraph_ids = [n.get("entity_id") for n in bfs_nodes]
|
|
||||||
# Nodes
|
|
||||||
for n in bfs_nodes:
|
|
||||||
node_id = n.get("entity_id")
|
|
||||||
if node_id not in seen_nodes:
|
|
||||||
result.nodes.append(
|
|
||||||
KnowledgeGraphNode(
|
|
||||||
id=node_id,
|
|
||||||
labels=[node_id],
|
|
||||||
properties=dict(n),
|
|
||||||
)
|
|
||||||
)
|
|
||||||
seen_nodes.add(node_id)
|
|
||||||
# Edges
|
|
||||||
if subgraph_ids:
|
|
||||||
edge_query = """
|
|
||||||
MATCH (a:base)-[r]-(b:base)
|
|
||||||
WHERE a.entity_id IN $ids AND b.entity_id IN $ids
|
|
||||||
RETURN DISTINCT r, a, b
|
|
||||||
"""
|
"""
|
||||||
edge_result = await session.run(edge_query, ids=subgraph_ids)
|
result_set = None
|
||||||
async for record in edge_result:
|
try:
|
||||||
r = record["r"]
|
result_set = await session.run(
|
||||||
a = record["a"]
|
main_query, {"max_nodes": max_nodes}
|
||||||
b = record["b"]
|
)
|
||||||
edge_id = f"{a.get('entity_id')}-{b.get('entity_id')}"
|
record = await result_set.single()
|
||||||
if edge_id not in seen_edges:
|
finally:
|
||||||
result.edges.append(
|
if result_set:
|
||||||
KnowledgeGraphEdge(
|
await result_set.consume()
|
||||||
id=edge_id,
|
|
||||||
type="DIRECTED",
|
else:
|
||||||
source=a.get("entity_id"),
|
bfs_query = """
|
||||||
target=b.get("entity_id"),
|
MATCH (start) WHERE start.entity_id = $entity_id
|
||||||
properties=dict(r),
|
WITH start
|
||||||
|
CALL {
|
||||||
|
WITH start
|
||||||
|
MATCH path = (start)-[*0..$max_depth]-(node)
|
||||||
|
WITH nodes(path) AS path_nodes, relationships(path) AS path_rels
|
||||||
|
UNWIND path_nodes AS n
|
||||||
|
WITH collect(DISTINCT n) AS all_nodes, collect(DISTINCT path_rels) AS all_rel_lists
|
||||||
|
WITH all_nodes, reduce(r = [], x IN all_rel_lists | r + x) AS all_rels
|
||||||
|
RETURN all_nodes, all_rels
|
||||||
|
}
|
||||||
|
WITH all_nodes AS nodes, all_rels AS relationships, size(all_nodes) AS total_nodes
|
||||||
|
|
||||||
|
// Apply node limiting here
|
||||||
|
WITH CASE
|
||||||
|
WHEN total_nodes <= $max_nodes THEN nodes
|
||||||
|
ELSE nodes[0..$max_nodes]
|
||||||
|
END AS limited_nodes,
|
||||||
|
relationships,
|
||||||
|
total_nodes,
|
||||||
|
total_nodes > $max_nodes AS is_truncated
|
||||||
|
UNWIND limited_nodes AS node
|
||||||
|
WITH collect({node: node}) AS node_info, relationships, total_nodes, is_truncated
|
||||||
|
RETURN node_info, relationships, total_nodes, is_truncated
|
||||||
|
"""
|
||||||
|
result_set = None
|
||||||
|
try:
|
||||||
|
result_set = await session.run(
|
||||||
|
bfs_query,
|
||||||
|
{
|
||||||
|
"entity_id": node_label,
|
||||||
|
"max_depth": max_depth,
|
||||||
|
"max_nodes": max_nodes,
|
||||||
|
},
|
||||||
|
)
|
||||||
|
record = await result_set.single()
|
||||||
|
if not record:
|
||||||
|
logger.debug(f"No record found for node {node_label}")
|
||||||
|
return result
|
||||||
|
|
||||||
|
for node_info in record["node_info"]:
|
||||||
|
node = node_info["node"]
|
||||||
|
node_id = node.id
|
||||||
|
if node_id not in seen_nodes:
|
||||||
|
seen_nodes.add(node_id)
|
||||||
|
result.nodes.append(
|
||||||
|
KnowledgeGraphNode(
|
||||||
|
id=f"{node_id}",
|
||||||
|
labels=[node.get("entity_id")],
|
||||||
|
properties=dict(node),
|
||||||
|
)
|
||||||
)
|
)
|
||||||
)
|
|
||||||
seen_edges.add(edge_id)
|
for rel in record["relationships"]:
|
||||||
await edge_result.consume()
|
edge_id = rel.id
|
||||||
logger.info(
|
if edge_id not in seen_edges:
|
||||||
f"Subgraph query successful | Node count: {len(result.nodes)} | Edge count: {len(result.edges)}"
|
seen_edges.add(edge_id)
|
||||||
)
|
start = rel.start_node
|
||||||
return result
|
end = rel.end_node
|
||||||
|
result.edges.append(
|
||||||
|
KnowledgeGraphEdge(
|
||||||
|
id=f"{edge_id}",
|
||||||
|
type=rel.type,
|
||||||
|
source=f"{start.id}",
|
||||||
|
target=f"{end.id}",
|
||||||
|
properties=dict(rel),
|
||||||
|
)
|
||||||
|
)
|
||||||
|
|
||||||
|
logger.info(
|
||||||
|
f"Subgraph query successful | Node count: {len(result.nodes)} | Edge count: {len(result.edges)}"
|
||||||
|
)
|
||||||
|
|
||||||
|
return result
|
||||||
|
|
||||||
|
finally:
|
||||||
|
if result_set:
|
||||||
|
await result_set.consume()
|
||||||
|
|
||||||
|
except Exception as e:
|
||||||
|
logger.error(f"Error getting knowledge graph: {str(e)}")
|
||||||
|
return result
|
||||||
|
|
|
||||||
Loading…
Add table
Reference in a new issue